chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java - Issue 1955173003: Test thread equality when initiating PWEnv class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

Issue 1955173003: Test thread equality when initiating PWEnv class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebEnvironment.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

index e3a5494fa1c1cf38180e231e381d92c04bb2ab49..0d1fca755b6aad39a09b3d7be61165e83a243279 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java

@@ -14,7 +14,6 @@ import android.test.suitebuilder.annotation.SmallTest;

import android.view.View;

import org.chromium.base.ContextUtils;

-import org.chromium.base.test.util.DisabledTest;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;

import org.chromium.chrome.test.util.browser.notifications.MockNotificationManagerProxy;

@@ -103,9 +102,7 @@ public class ListUrlsActivityTest extends InstrumentationTestCase {

assertEquals(URL, testContextWrapper.startedIntents.get(0).getDataString());

}

- // Onboarding tests are broken (see bug 608872)

@SmallTest

- @DisabledTest

public void testUrlsListEmptyInOnboarding() {

// In onboarding, we scan for nearby URLs but do not send them to the resolution service to

// protect the user's privacy. This test checks that the URL list, which only displays