Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1955163002: Adds a gn argument for boringssl path (Closed)

Created:
4 years, 7 months ago by zra
Modified:
4 years, 7 months ago
Reviewers:
jsimmons1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds a gn argument for boringssl path Fixes Flutter build. There should be no need for Flutter to set the flag. Mojo will need to set the flag. R=jsimmons@google.com Committed: https://github.com/dart-lang/sdk/commit/57fea4f10ba179355f8381d399345afe127dfaa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/bin/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 7 months ago (2016-05-06 21:59:22 UTC) #2
jsimmons1
On 2016/05/06 21:59:22, zra wrote: lgtm
4 years, 7 months ago (2016-05-06 22:01:37 UTC) #3
zra
4 years, 7 months ago (2016-05-06 22:05:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57fea4f10ba179355f8381d399345afe127dfaa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698