DescriptionReland of chromeos: Turn off displays on suspend (patchset #2 id:250001 of https://codereview.chromium.org/1949753004/ )
Reason for revert:
The issue is fixed in the kernel. It was a problem with suspend/resume and the display encoder for a platform that is fixed in https://chromium-review.googlesource.com/#/c/342845/
Original issue's description:
> Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of https://codereview.chromium.org/1861593002/ )
>
> Reason for revert:
> With this patch, the internal display (on oak, at least) stays black on resume from suspend.
>
> Perhaps "the delay for restoring the display state" really is important after all.
>
> BUG=chrome-os-partner:52916
>
> Original issue's description:
> > chromeos: Turn off displays on suspend
> >
> > To handle lucid sleep (where we need to silently resume the system), turn
> > off the displays on suspend. This also removes the delay for restoring the
> > display state added in "On resume perform a delayed call to
> > SetDisplayPower()" According to the bug for that change, it didn't seem to
> > help with the issue anyways.
> >
> > BUG=535021
> > TEST=suspend/resume of various cros platforms with/without external monitor
> > connected
> >
> > Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> > Cr-Commit-Position: refs/heads/master@{#389875}
>
> TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromium.org,tbroch@chromium.org,ejcaruso@chromium.org,dnicoara@chromium.org,marcheu@google.com,spang@chromium.org,dbasehore@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=535021
>
> Committed: https://crrev.com/a3145f9cee03fd27c8c04511e95b8217f489889c
> Cr-Commit-Position: refs/heads/master@{#392006}
TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromium.org,tbroch@chromium.org,ejcaruso@chromium.org,dnicoara@chromium.org,marcheu@google.com,spang@chromium.org,djkurtz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:52916
Committed: https://crrev.com/938c011911bb26af1647b538c5dfd077d27e84ea
Cr-Commit-Position: refs/heads/master@{#392161}
Patch Set 1 #
Messages
Total messages: 10 (3 generated)
|