Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1955103002: Reland of chromeos: Turn off displays on suspend (Closed)

Created:
4 years, 7 months ago by dbasehore
Modified:
4 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of chromeos: Turn off displays on suspend (patchset #2 id:250001 of https://codereview.chromium.org/1949753004/ ) Reason for revert: The issue is fixed in the kernel. It was a problem with suspend/resume and the display encoder for a platform that is fixed in https://chromium-review.googlesource.com/#/c/342845/ Original issue's description: > Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of https://codereview.chromium.org/1861593002/ ) > > Reason for revert: > With this patch, the internal display (on oak, at least) stays black on resume from suspend. > > Perhaps "the delay for restoring the display state" really is important after all. > > BUG=chrome-os-partner:52916 > > Original issue's description: > > chromeos: Turn off displays on suspend > > > > To handle lucid sleep (where we need to silently resume the system), turn > > off the displays on suspend. This also removes the delay for restoring the > > display state added in "On resume perform a delayed call to > > SetDisplayPower()" According to the bug for that change, it didn't seem to > > help with the issue anyways. > > > > BUG=535021 > > TEST=suspend/resume of various cros platforms with/without external monitor > > connected > > > > Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631 > > Cr-Commit-Position: refs/heads/master@{#389875} > > TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromium.org,tbroch@chromium.org,ejcaruso@chromium.org,dnicoara@chromium.org,marcheu@google.com,spang@chromium.org,dbasehore@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=535021 > > Committed: https://crrev.com/a3145f9cee03fd27c8c04511e95b8217f489889c > Cr-Commit-Position: refs/heads/master@{#392006} TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromium.org,tbroch@chromium.org,ejcaruso@chromium.org,dnicoara@chromium.org,marcheu@google.com,spang@chromium.org,djkurtz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:52916 Committed: https://crrev.com/938c011911bb26af1647b538c5dfd077d27e84ea Cr-Commit-Position: refs/heads/master@{#392161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -134 lines) Patch
M ui/display/chromeos/display_configurator.h View 2 chunks +13 lines, -7 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 11 chunks +50 lines, -52 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 10 chunks +86 lines, -75 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dbasehore
Created Reland of chromeos: Turn off displays on suspend
4 years, 7 months ago (2016-05-06 20:22:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955103002/1
4 years, 7 months ago (2016-05-06 20:22:22 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-06 20:22:25 UTC) #4
dnicoara
lgtm
4 years, 7 months ago (2016-05-06 21:25:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955103002/1
4 years, 7 months ago (2016-05-06 21:27:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 21:29:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 21:31:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/938c011911bb26af1647b538c5dfd077d27e84ea
Cr-Commit-Position: refs/heads/master@{#392161}

Powered by Google App Engine
This is Rietveld 408576698