Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1955073002: LayoutObject::paintingLayer() to correctly handle column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1464 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 layoutView = layoutView->frame()->ownerLayoutObject()->view(); 1475 layoutView = layoutView->frame()->ownerLayoutObject()->view();
1476 mapToVisualRectInAncestorSpace(layoutView, rect); 1476 mapToVisualRectInAncestorSpace(layoutView, rect);
1477 return rect.intersects(LayoutRect(layoutView->frameView()->getScrollableArea ()->visibleContentRectDouble())); 1477 return rect.intersects(LayoutRect(layoutView->frameView()->getScrollableArea ()->visibleContentRectDouble()));
1478 } 1478 }
1479 1479
1480 PaintInvalidationReason LayoutBox::invalidatePaintIfNeeded(const PaintInvalidati onState& paintInvalidationState) 1480 PaintInvalidationReason LayoutBox::invalidatePaintIfNeeded(const PaintInvalidati onState& paintInvalidationState)
1481 { 1481 {
1482 if (hasBoxDecorationBackground() 1482 if (hasBoxDecorationBackground()
1483 // We also paint overflow controls in background phase. 1483 // We also paint overflow controls in background phase.
1484 || (hasOverflowClip() && getScrollableArea()->hasOverflowControls())) { 1484 || (hasOverflowClip() && getScrollableArea()->hasOverflowControls())) {
1485 PaintLayer& layer = paintInvalidationState.enclosingSelfPaintingLayer(*t his); 1485 PaintLayer& layer = paintInvalidationState.paintingLayer();
1486 if (layer.layoutObject() != this) 1486 if (layer.layoutObject() != this)
1487 layer.setNeedsPaintPhaseDescendantBlockBackgrounds(); 1487 layer.setNeedsPaintPhaseDescendantBlockBackgrounds();
1488 } 1488 }
1489 1489
1490 PaintInvalidationReason fullInvalidationReason = fullPaintInvalidationReason (); 1490 PaintInvalidationReason fullInvalidationReason = fullPaintInvalidationReason ();
1491 // If the current paint invalidation reason is PaintInvalidationDelayedFull, then this paint invalidation can delayed if the 1491 // If the current paint invalidation reason is PaintInvalidationDelayedFull, then this paint invalidation can delayed if the
1492 // LayoutBox in question is not on-screen. The logic to decide whether this is appropriate exists at the site of the original 1492 // LayoutBox in question is not on-screen. The logic to decide whether this is appropriate exists at the site of the original
1493 // paint invalidation that chose PaintInvalidationDelayedFull. 1493 // paint invalidation that chose PaintInvalidationDelayedFull.
1494 if (fullInvalidationReason == PaintInvalidationDelayedFull) { 1494 if (fullInvalidationReason == PaintInvalidationDelayedFull) {
1495 if (!intersectsVisibleViewport()) 1495 if (!intersectsVisibleViewport())
(...skipping 3280 matching lines...) Expand 10 before | Expand all | Expand 10 after
4776 4776
4777 void LayoutBox::clearPercentHeightDescendants() 4777 void LayoutBox::clearPercentHeightDescendants()
4778 { 4778 {
4779 for (LayoutObject* curr = slowFirstChild(); curr; curr = curr->nextInPreOrde r(this)) { 4779 for (LayoutObject* curr = slowFirstChild(); curr; curr = curr->nextInPreOrde r(this)) {
4780 if (curr->isBox()) 4780 if (curr->isBox())
4781 toLayoutBox(curr)->removeFromPercentHeightContainer(); 4781 toLayoutBox(curr)->removeFromPercentHeightContainer();
4782 } 4782 }
4783 } 4783 }
4784 4784
4785 } // namespace blink 4785 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698