third_party/WebKit/LayoutTests/fast/multicol/span/remove-span-all-under-layer.html - Issue 1955073002: LayoutObject::paintingLayer() to correctly handle column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/span/remove-span-all-under-layer.html

Issue 1955073002: LayoutObject::paintingLayer() to correctly handle column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div style="-webkit-columns:2;">
	mstensho (USE GERRIT) 2016/05/06 19:59:38 Optional nit: no need to -webkit- prefix this or c Optional nit: no need to -webkit- prefix this or column-span anymore.
	3 <div style="position: relative">

	4 <div id="span-all" style="-webkit-column-span:all;">

	5 </div>

	6 </div>

	7 <script>

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10 onload = function() {
	mstensho (USE GERRIT) 2016/05/06 19:59:38 Probably safer to put "document.body.offsetTop;" i Probably safer to put "document.body.offsetTop;" in front of the display style change, to be sure that we have laid out at that point. There should be no need to wrap it inside an onload handler, though.
	11 document.getElementById('span-all').style.display = 'none';

	12 };

	13 </script>

	14 Passes if no crash.

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/span/remove-span-all-under-layer-expected.txt » ('j') | no next file with comments »