Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1955063002:
Change to sRGB default for codec generated images. (Closed)
DescriptionChange to sRGB default for codec generated images.
Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955063002
Committed: https://skia.googlesource.com/skia/+/7acc00853174361cf921ecac8fbeaf6812f53eed
Patch Set 1 #Patch Set 2 : Sync and try flip again. All tests working in debug #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Change to sRGB default for codec generated images. BUG=skia: ========== to ========== Change to sRGB default for codec generated images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Change to sRGB default for codec generated images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Change to sRGB default for codec generated images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + brianosman@google.com, msarett@google.com
Description was changed from ========== Change to sRGB default for codec generated images. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Change to sRGB default for codec generated images. Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Looks good to me
lgtm
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955063002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
Sync and try flip again. All tests working in debug
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955063002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from brianosman@google.com Link to the patchset: https://codereview.chromium.org/1955063002/#ps20001 (title: "Sync and try flip again. All tests working in debug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955063002/20001
Message was sent while issue was closed.
Description was changed from ========== Change to sRGB default for codec generated images. Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Change to sRGB default for codec generated images. Compared the gm and skps for 8888 and srgb. There are no differences for 8888, there are 100 differences for sRGB, but the 100 look correct compared to the old ones. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/7acc00853174361cf921ecac8fbeaf6812f53eed ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7acc00853174361cf921ecac8fbeaf6812f53eed
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1982323002/ by herb@google.com. The reason for reverting is: TBR=brianosman@google.com. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
