Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1955053003: [chromecast] Delete CastMojoMediaApplication. (Closed)

Created:
4 years, 7 months ago by alokp
Modified:
4 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Delete CastMojoMediaApplication. Use media::MojoMediaApplication instead. CastMojoMediaApplication was created for the sole purpose of running the media app on cast media thread. Now that EmbeddedApplicationRunner accepts an existing thread, there is no need for CastMojoMediaApplication to exist. BUG=594234 Committed: https://crrev.com/24e36c4845a886525b260ee1b0b86802d59e768f Cr-Commit-Position: refs/heads/master@{#392246}

Patch Set 1 #

Patch Set 2 : nogncheck for conditional include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -137 lines) Patch
M chromecast/browser/cast_content_browser_client.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M chromecast/browser/media/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chromecast/browser/media/cast_mojo_media_application.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chromecast/browser/media/cast_mojo_media_application.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
alokp
This ought to make you happy :)
4 years, 7 months ago (2016-05-06 21:04:15 UTC) #2
xhwang
Indeed, welcome back and thank you! LGTM
4 years, 7 months ago (2016-05-06 21:06:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955053003/1
4 years, 7 months ago (2016-05-07 02:50:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/156854)
4 years, 7 months ago (2016-05-07 02:57:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955053003/20001
4 years, 7 months ago (2016-05-07 04:22:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-07 05:19:04 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 05:20:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24e36c4845a886525b260ee1b0b86802d59e768f
Cr-Commit-Position: refs/heads/master@{#392246}

Powered by Google App Engine
This is Rietveld 408576698