Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1955033003: MD User Manager: Open URLs in a foreground tabs (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Open URLs in a foreground tabs BUG=609779, 563722 Committed: https://crrev.com/87d74bbadc6fc4e28e6b5559bdda6014284d059f Cr-Commit-Position: refs/heads/master@{#392593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Moe
Roger, please review this change. Thank you.
4 years, 7 months ago (2016-05-06 21:29:13 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm
4 years, 7 months ago (2016-05-09 17:54:18 UTC) #4
Moe
Thank you Roger.
4 years, 7 months ago (2016-05-09 18:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955033003/1
4 years, 7 months ago (2016-05-09 18:18:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/210440)
4 years, 7 months ago (2016-05-09 19:47:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1955033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1955033003/1
4 years, 7 months ago (2016-05-10 13:56:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 13:59:56 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 14:01:03 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/87d74bbadc6fc4e28e6b5559bdda6014284d059f
Cr-Commit-Position: refs/heads/master@{#392593}

Powered by Google App Engine
This is Rietveld 408576698