src/pdf/SkSinglyLinkedList.h - Issue 1955033002: SkAdvancedTypefaceMetrics: improve robustness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkSinglyLinkedList.h

Issue 1955033002: SkAdvancedTypefaceMetrics: improve robustness (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2016-05-06 (Friday) 09:17:03 EDT Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkSinglyLinkedList.h

diff --git a/src/pdf/SkSinglyLinkedList.h b/src/pdf/SkSinglyLinkedList.h

index c157c31d16c03e2543a82d6cb72f72e0d1fe5f33..c7101141d6421b1b0cbb2691e56002bc99a1f3fb 100644

--- a/src/pdf/SkSinglyLinkedList.h

+++ b/src/pdf/SkSinglyLinkedList.h

@@ -18,6 +18,7 @@ public:

~SkSinglyLinkedList() { this->reset(); }

void reset() {

SkASSERT(fHead != nullptr || nullptr == fTail);

+ // Use a while loop rather than recursion to avoid stack overflow.

Node* node = fHead;

while (node) {

Node* next = node->fNext;