SkAdvancedTypefaceMetrics: improve robustness

SkAdvancedTypefaceMetrics: improve robustness

Manually unwind linked list.

BUG=567031
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1955033002

Committed: https://skia.googlesource.com/skia/+/ebbdfe63a9643faa403f33282da9921427ca91eb

[hal.canary, 2016-05-06 13:08:19]

Description was changed from

==========
SkAdvancedTypefaceMetrics: improve robustness

Manually unwind linked list.

BUG=567031
==========

to

==========
SkAdvancedTypefaceMetrics: improve robustness

Manually unwind linked list.

BUG=567031
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-05-06 13:17:26]

Patchset #1 (id:1) has been deleted

[hal.canary, 2016-05-06 13:17:32]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 13:17:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955033002/20001

[hal.canary, 2016-05-06 13:25:02]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-05-06 13:25:02]

PTAL

[commit-bot: I haz the power, 2016-05-06 13:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 13:44:34]

Dry run: This issue passed the CQ dry run.

[tomhudson, 2016-05-06 14:07:09]

lgtm

https://codereview.chromium.org/1955033002/diff/20001/src/core/SkAdvancedType...
File src/core/SkAdvancedTypefaceMetrics.h (right):

https://codereview.chromium.org/1955033002/diff/20001/src/core/SkAdvancedType...
src/core/SkAdvancedTypefaceMetrics.h:22: class SkHackyAutoTDelete :
SkNoncopyable {
The semantics aren't exactly the same, but could we replace this with sk_sp<>?
This comment is undated, we don't know when "now" was without git blame, perhaps
Clank has been updated?

[hal.canary, 2016-05-06 14:21:00]

https://codereview.chromium.org/1955033002/diff/20001/src/core/SkAdvancedType...
File src/core/SkAdvancedTypefaceMetrics.h (right):

https://codereview.chromium.org/1955033002/diff/20001/src/core/SkAdvancedType...
src/core/SkAdvancedTypefaceMetrics.h:22: class SkHackyAutoTDelete :
SkNoncopyable {
On 2016/05/06 14:07:09, tomhudson wrote:
> The semantics aren't exactly the same, but could we replace this with sk_sp<>?
> This comment is undated, we don't know when "now" was without git blame,
perhaps
> Clank has been updated?

I plan on removing this class in a later CL, as I abstract out the linked list.

[hal.canary, 2016-05-06 14:21:05]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-05-06 14:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955033002/20001

[hal.canary, 2016-05-06 14:29:07]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2016-05-06 14:29:12]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-05-06 14:29:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1955033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1955033002/20001

[commit-bot: I haz the power, 2016-05-06 14:30:16]

Description was changed from

==========
SkAdvancedTypefaceMetrics: improve robustness

Manually unwind linked list.

BUG=567031
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkAdvancedTypefaceMetrics: improve robustness

Manually unwind linked list.

BUG=567031
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ebbdfe63a9643faa403f33282da9921427ca91eb
==========

[commit-bot: I haz the power, 2016-05-06 14:30:16]

Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/ebbdfe63a9643faa403f33282da9921427ca91eb