Issue 19550004: Reland r212020: Move Python setup/tear down logic into Forwarder ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19550004: Reland r212020: Move Python setup/tear down logic into Forwarder ... (Closed)

Created:
7 years, 5 months ago by Philippe

Modified:
7 years, 5 months ago

Reviewers:

CC:
chromium-reviews, craigdh+watch_chromium.org, kkania, frankf, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland r212020: Move Python setup/tear down logic into Forwarder ... Forwarder used to be a pain to setup/tear down across all the various harnesses. This CL should hopefully solve these issues by hiding these implementation details. The host daemon is now killed once the first time that the Forwarder class is used and the daemon running on the devices is also killed the first time a port is forwarded for a specific device. TBR=bulach@chromium.org BUG=242846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212582

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -168 lines)			Patch
M	build/android/adb_reverse_forwarder.py	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	build/android/bb_run_sharded_steps.py	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/base/base_test_runner.py	View	1	4 chunks	+18 lines, -24 lines	0 comments	Download
M	build/android/pylib/base/shard.py	View		3 chunks	+0 lines, -4 lines	0 comments	Download
M	build/android/pylib/chrome_test_server_spawner.py	View		8 chunks	+6 lines, -11 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View		5 chunks	+211 lines, -82 lines	0 comments	Download
M	build/android/pylib/host_driven/python_test_sharder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/run_py_tests.py	View		1 chunk	+4 lines, -9 lines	0 comments	Download
M	chrome/test/chromedriver/test_environment.py	View		1 chunk	+3 lines, -8 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/adb_commands.py	View		2 chunks	+5 lines, -16 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_backend.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Philippe

FYI Marcus, I'm going to reland this. Patch set 1 vs patch set 2 shows ...

7 years, 5 months ago (2013-07-19 13:26:48 UTC) #1

Philippe

7 years, 5 months ago (2013-07-19 13:30:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r212582 (presubmit successful).

Expand Messages | Collapse Messages