Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 1954973004: Remove MostVisitedSites => SupervisedUserService dep. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/ntp/most_visited_sites_bridge.h" 5 #include "chrome/browser/android/ntp/most_visited_sites_bridge.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
11 #include "base/android/jni_string.h" 11 #include "base/android/jni_string.h"
12 #include "base/android/scoped_java_ref.h" 12 #include "base/android/scoped_java_ref.h"
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/callback.h" 14 #include "base/callback.h"
15 #include "chrome/browser/android/ntp/popular_sites.h" 15 #include "chrome/browser/android/ntp/popular_sites.h"
16 #include "chrome/browser/browser_process.h" 16 #include "chrome/browser/browser_process.h"
17 #include "chrome/browser/history/top_sites_factory.h" 17 #include "chrome/browser/history/top_sites_factory.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/profiles/profile_android.h" 19 #include "chrome/browser/profiles/profile_android.h"
20 #include "chrome/browser/search/suggestions/suggestions_service_factory.h" 20 #include "chrome/browser/search/suggestions/suggestions_service_factory.h"
21 #include "chrome/browser/search_engines/template_url_service_factory.h" 21 #include "chrome/browser/search_engines/template_url_service_factory.h"
22 #include "chrome/browser/supervised_user/supervised_user_service.h"
23 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
24 #include "chrome/browser/supervised_user/supervised_user_url_filter.h"
22 #include "chrome/browser/thumbnails/thumbnail_list_source.h" 25 #include "chrome/browser/thumbnails/thumbnail_list_source.h"
23 #include "components/history/core/browser/top_sites.h" 26 #include "components/history/core/browser/top_sites.h"
24 #include "content/public/browser/url_data_source.h" 27 #include "content/public/browser/url_data_source.h"
25 #include "jni/MostVisitedSites_jni.h" 28 #include "jni/MostVisitedSites_jni.h"
26 #include "ui/gfx/android/java_bitmap.h" 29 #include "ui/gfx/android/java_bitmap.h"
27 #include "url/gurl.h" 30 #include "url/gurl.h"
28 31
29 using base::android::AttachCurrentThread; 32 using base::android::AttachCurrentThread;
30 using base::android::ConvertJavaStringToUTF8; 33 using base::android::ConvertJavaStringToUTF8;
31 using base::android::ScopedJavaGlobalRef; 34 using base::android::ScopedJavaGlobalRef;
(...skipping 10 matching lines...) Expand all
42 JNIEnv* env = AttachCurrentThread(); 45 JNIEnv* env = AttachCurrentThread();
43 ScopedJavaLocalRef<jobject> j_bitmap; 46 ScopedJavaLocalRef<jobject> j_bitmap;
44 if (bitmap) 47 if (bitmap)
45 j_bitmap = gfx::ConvertToJavaBitmap(bitmap); 48 j_bitmap = gfx::ConvertToJavaBitmap(bitmap);
46 Java_ThumbnailCallback_onMostVisitedURLsThumbnailAvailable( 49 Java_ThumbnailCallback_onMostVisitedURLsThumbnailAvailable(
47 env, j_callback->obj(), j_bitmap.obj(), is_local_thumbnail); 50 env, j_callback->obj(), j_bitmap.obj(), is_local_thumbnail);
48 } 51 }
49 52
50 } // namespace 53 } // namespace
51 54
52 class MostVisitedSitesBridge::Observer 55 MostVisitedSitesBridge::SupervisorBridge::SupervisorBridge(Profile* profile)
56 : profile_(profile),
57 register_observer_(this) {
58 register_observer_.Add(
59 SupervisedUserServiceFactory::GetForProfile(profile_));
60 }
61
62 void
63 MostVisitedSitesBridge::SupervisorBridge::SetObserver(Observer* new_observer) {
64 if (new_observer)
65 DCHECK(!supervisor_observer_);
66 else
67 DCHECK(supervisor_observer_);
68
69 supervisor_observer_ = new_observer;
70 }
71
72 bool MostVisitedSitesBridge::SupervisorBridge::IsBlocked(const GURL& url) {
73 SupervisedUserService* supervised_user_service =
74 SupervisedUserServiceFactory::GetForProfile(profile_);
75 auto url_filter = supervised_user_service->GetURLFilterForUIThread();
76 return url_filter->GetFilteringBehaviorForURL(url) ==
77 SupervisedUserURLFilter::FilteringBehavior::BLOCK;
78 }
79
80 std::vector<MostVisitedSitesSupervisor::Whitelist>
81 MostVisitedSitesBridge::SupervisorBridge::whitelists() {
82 std::vector<MostVisitedSitesSupervisor::Whitelist> results;
83 SupervisedUserService* supervised_user_service =
84 SupervisedUserServiceFactory::GetForProfile(profile_);
85 for (const auto& whitelist : supervised_user_service->whitelists()) {
86 results.emplace_back(Whitelist{
87 whitelist->title(),
88 whitelist->entry_point(),
89 whitelist->large_icon_path(),
90 });
91 }
92 return results;
93 }
94
95 bool MostVisitedSitesBridge::SupervisorBridge::IsChildProfile() {
96 return profile_->IsChild();
97 }
98
99 void MostVisitedSitesBridge::SupervisorBridge::OnURLFilterChanged() {
100 if (supervisor_observer_)
101 supervisor_observer_->OnBlockedSitesChanged();
102 }
103
104 class MostVisitedSitesBridge::JavaObserver
53 : public MostVisitedSites::Observer { 105 : public MostVisitedSites::Observer {
54 public: 106 public:
55 Observer(JNIEnv* env, const JavaParamRef<jobject>& obj); 107 JavaObserver(JNIEnv* env, const JavaParamRef<jobject>& obj);
56 108
57 void OnMostVisitedURLsAvailable( 109 void OnMostVisitedURLsAvailable(
58 const MostVisitedSites::SuggestionsVector& suggestions) override; 110 const MostVisitedSites::SuggestionsVector& suggestions) override;
59 111
60 void OnPopularURLsAvailable( 112 void OnPopularURLsAvailable(
61 const MostVisitedSites::PopularSitesVector& sites) override; 113 const MostVisitedSites::PopularSitesVector& sites) override;
62 114
63 private: 115 private:
64 ScopedJavaGlobalRef<jobject> observer_; 116 ScopedJavaGlobalRef<jobject> observer_;
65 117
66 DISALLOW_COPY_AND_ASSIGN(Observer); 118 DISALLOW_COPY_AND_ASSIGN(JavaObserver);
67 }; 119 };
68 120
69 MostVisitedSitesBridge::Observer::Observer( 121 MostVisitedSitesBridge::JavaObserver::JavaObserver(
70 JNIEnv* env, const JavaParamRef<jobject>& obj) 122 JNIEnv* env, const JavaParamRef<jobject>& obj)
71 : observer_(env, obj) {} 123 : observer_(env, obj) {}
72 124
73 void MostVisitedSitesBridge::Observer::OnMostVisitedURLsAvailable( 125 void MostVisitedSitesBridge::JavaObserver::OnMostVisitedURLsAvailable(
74 const MostVisitedSites::SuggestionsVector& suggestions) { 126 const MostVisitedSites::SuggestionsVector& suggestions) {
75 JNIEnv* env = AttachCurrentThread(); 127 JNIEnv* env = AttachCurrentThread();
76 std::vector<base::string16> titles; 128 std::vector<base::string16> titles;
77 std::vector<std::string> urls; 129 std::vector<std::string> urls;
78 std::vector<std::string> whitelist_icon_paths; 130 std::vector<std::string> whitelist_icon_paths;
79 titles.reserve(suggestions.size()); 131 titles.reserve(suggestions.size());
80 urls.reserve(suggestions.size()); 132 urls.reserve(suggestions.size());
81 whitelist_icon_paths.reserve(suggestions.size()); 133 whitelist_icon_paths.reserve(suggestions.size());
82 for (const auto& suggestion : suggestions) { 134 for (const auto& suggestion : suggestions) {
83 titles.emplace_back(suggestion.title); 135 titles.emplace_back(suggestion.title);
84 urls.emplace_back(suggestion.url.spec()); 136 urls.emplace_back(suggestion.url.spec());
85 whitelist_icon_paths.emplace_back(suggestion.whitelist_icon_path.value()); 137 whitelist_icon_paths.emplace_back(suggestion.whitelist_icon_path.value());
86 } 138 }
87 Java_MostVisitedURLsObserver_onMostVisitedURLsAvailable( 139 Java_MostVisitedURLsObserver_onMostVisitedURLsAvailable(
88 env, observer_.obj(), ToJavaArrayOfStrings(env, titles).obj(), 140 env, observer_.obj(), ToJavaArrayOfStrings(env, titles).obj(),
89 ToJavaArrayOfStrings(env, urls).obj(), 141 ToJavaArrayOfStrings(env, urls).obj(),
90 ToJavaArrayOfStrings(env, whitelist_icon_paths).obj()); 142 ToJavaArrayOfStrings(env, whitelist_icon_paths).obj());
91 } 143 }
92 144
93 void MostVisitedSitesBridge::Observer::OnPopularURLsAvailable( 145 void MostVisitedSitesBridge::JavaObserver::OnPopularURLsAvailable(
94 const MostVisitedSites::PopularSitesVector& sites) { 146 const MostVisitedSites::PopularSitesVector& sites) {
95 JNIEnv* env = AttachCurrentThread(); 147 JNIEnv* env = AttachCurrentThread();
96 std::vector<std::string> urls; 148 std::vector<std::string> urls;
97 std::vector<std::string> favicon_urls; 149 std::vector<std::string> favicon_urls;
98 std::vector<std::string> large_icon_urls; 150 std::vector<std::string> large_icon_urls;
99 for (const auto& site : sites) { 151 for (const auto& site : sites) {
100 urls.emplace_back(site.url.spec()); 152 urls.emplace_back(site.url.spec());
101 favicon_urls.emplace_back(site.favicon_url.spec()); 153 favicon_urls.emplace_back(site.favicon_url.spec());
102 large_icon_urls.emplace_back(site.large_icon_url.spec()); 154 large_icon_urls.emplace_back(site.large_icon_url.spec());
103 } 155 }
104 Java_MostVisitedURLsObserver_onPopularURLsAvailable( 156 Java_MostVisitedURLsObserver_onPopularURLsAvailable(
105 env, observer_.obj(), ToJavaArrayOfStrings(env, urls).obj(), 157 env, observer_.obj(), ToJavaArrayOfStrings(env, urls).obj(),
106 ToJavaArrayOfStrings(env, favicon_urls).obj(), 158 ToJavaArrayOfStrings(env, favicon_urls).obj(),
107 ToJavaArrayOfStrings(env, large_icon_urls).obj()); 159 ToJavaArrayOfStrings(env, large_icon_urls).obj());
108 } 160 }
109 161
110 MostVisitedSitesBridge::MostVisitedSitesBridge(Profile* profile) 162 MostVisitedSitesBridge::MostVisitedSitesBridge(Profile* profile)
111 : most_visited_(profile->GetPrefs(), 163 : supervisor_(profile),
164 most_visited_(profile->GetPrefs(),
112 TemplateURLServiceFactory::GetForProfile(profile), 165 TemplateURLServiceFactory::GetForProfile(profile),
113 g_browser_process->variations_service(), 166 g_browser_process->variations_service(),
114 profile->GetRequestContext(), 167 profile->GetRequestContext(),
115 TopSitesFactory::GetForProfile(profile), 168 TopSitesFactory::GetForProfile(profile),
116 SuggestionsServiceFactory::GetForProfile(profile), 169 SuggestionsServiceFactory::GetForProfile(profile),
117 profile->IsChild(), 170 &supervisor_) {
118 profile) {
119 // Register the thumbnails debugging page. 171 // Register the thumbnails debugging page.
120 // TODO(sfiera): find thumbnails a home. They don't belong here. 172 // TODO(sfiera): find thumbnails a home. They don't belong here.
121 content::URLDataSource::Add(profile, new ThumbnailListSource(profile)); 173 content::URLDataSource::Add(profile, new ThumbnailListSource(profile));
122 } 174 }
123 175
124 MostVisitedSitesBridge::~MostVisitedSitesBridge() {} 176 MostVisitedSitesBridge::~MostVisitedSitesBridge() {}
125 177
126 void MostVisitedSitesBridge::Destroy( 178 void MostVisitedSitesBridge::Destroy(
127 JNIEnv* env, const JavaParamRef<jobject>& obj) { 179 JNIEnv* env, const JavaParamRef<jobject>& obj) {
128 delete this; 180 delete this;
129 } 181 }
130 182
131 void MostVisitedSitesBridge::SetMostVisitedURLsObserver( 183 void MostVisitedSitesBridge::SetMostVisitedURLsObserver(
132 JNIEnv* env, 184 JNIEnv* env,
133 const JavaParamRef<jobject>& obj, 185 const JavaParamRef<jobject>& obj,
134 const JavaParamRef<jobject>& j_observer, 186 const JavaParamRef<jobject>& j_observer,
135 jint num_sites) { 187 jint num_sites) {
136 observer_.reset(new Observer(env, j_observer)); 188 java_observer_.reset(new JavaObserver(env, j_observer));
137 most_visited_.SetMostVisitedURLsObserver(observer_.get(), num_sites); 189 most_visited_.SetMostVisitedURLsObserver(java_observer_.get(), num_sites);
138 } 190 }
139 191
140 void MostVisitedSitesBridge::GetURLThumbnail( 192 void MostVisitedSitesBridge::GetURLThumbnail(
141 JNIEnv* env, 193 JNIEnv* env,
142 const JavaParamRef<jobject>& obj, 194 const JavaParamRef<jobject>& obj,
143 const JavaParamRef<jstring>& j_url, 195 const JavaParamRef<jstring>& j_url,
144 const JavaParamRef<jobject>& j_callback_obj) { 196 const JavaParamRef<jobject>& j_callback_obj) {
145 std::unique_ptr<ScopedJavaGlobalRef<jobject>> j_callback( 197 std::unique_ptr<ScopedJavaGlobalRef<jobject>> j_callback(
146 new ScopedJavaGlobalRef<jobject>(env, j_callback_obj)); 198 new ScopedJavaGlobalRef<jobject>(env, j_callback_obj));
147 auto callback = base::Bind(&CallJavaWithBitmap, base::Passed(&j_callback)); 199 auto callback = base::Bind(&CallJavaWithBitmap, base::Passed(&j_callback));
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 } 233 }
182 234
183 static jlong Init(JNIEnv* env, 235 static jlong Init(JNIEnv* env,
184 const JavaParamRef<jobject>& obj, 236 const JavaParamRef<jobject>& obj,
185 const JavaParamRef<jobject>& jprofile) { 237 const JavaParamRef<jobject>& jprofile) {
186 MostVisitedSitesBridge* most_visited_sites = 238 MostVisitedSitesBridge* most_visited_sites =
187 new MostVisitedSitesBridge( 239 new MostVisitedSitesBridge(
188 ProfileAndroid::FromProfileAndroid(jprofile)); 240 ProfileAndroid::FromProfileAndroid(jprofile));
189 return reinterpret_cast<intptr_t>(most_visited_sites); 241 return reinterpret_cast<intptr_t>(most_visited_sites);
190 } 242 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698