Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1954963002: X87: [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operator… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. port a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 (r36009) original commit message: Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. BUG= Committed: https://crrev.com/f68562ee0beac21812ec035cc0d5fc6e68e06b35 Cr-Commit-Position: refs/heads/master@{#36057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 3 chunks +58 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-06 02:13:27 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-06 02:18:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954963002/1
4 years, 7 months ago (2016-05-06 02:39:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 07:27:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:28:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f68562ee0beac21812ec035cc0d5fc6e68e06b35
Cr-Commit-Position: refs/heads/master@{#36057}

Powered by Google App Engine
This is Rietveld 408576698