Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1954903002: [Sheriff] Build libjpeg_turbo in PIC mode for x86 and x64. (Closed)

Created:
4 years, 7 months ago by Dmitry Skiba
Modified:
4 years, 7 months ago
Reviewers:
msarett, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sheriff] Build libjpeg_turbo in PIC mode for x86 and x64. This CL fixes 'shared library text segment is not shareable' error observed on Android x86 Builder (dbg) bot. Committed: https://crrev.com/58a611fea9de21de789f594b0e95c5147d74b519 Cr-Commit-Position: refs/heads/master@{#391959}

Patch Set 1 #

Patch Set 2 : Remove ELF #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dmitry Skiba
4 years, 7 months ago (2016-05-05 22:02:49 UTC) #2
msarett
LGTM if the build succeeds!
4 years, 7 months ago (2016-05-05 22:04:39 UTC) #3
Dmitry Skiba
PTAL (this fixes issue on Android x86 Builder (dbg) bot)
4 years, 7 months ago (2016-05-05 22:05:16 UTC) #5
jbudorick
lgtm stamp
4 years, 7 months ago (2016-05-05 22:07:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954903002/1
4 years, 7 months ago (2016-05-05 22:22:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/106902)
4 years, 7 months ago (2016-05-05 22:41:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954903002/20001
4 years, 7 months ago (2016-05-05 22:53:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 00:07:05 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 00:09:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58a611fea9de21de789f594b0e95c5147d74b519
Cr-Commit-Position: refs/heads/master@{#391959}

Powered by Google App Engine
This is Rietveld 408576698