Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 19549002: Deprecate some debugger methods (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Yang, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Deprecate some debugger methods These methods have been superceeded by equivalents accepting object arguments exposing more details. BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M include/v8-debug.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8-debug.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/d8-debug.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 5 months ago (2013-07-17 08:58:25 UTC) #1
Yang
On 2013/07/17 08:58:25, Yury Semikhatsky wrote: LGTM, but we should also reflect the changes in ...
7 years, 5 months ago (2013-07-17 09:01:42 UTC) #2
loislo
lgtm
7 years, 5 months ago (2013-07-17 09:02:15 UTC) #3
yurys
On 2013/07/17 09:01:42, Yang wrote: > On 2013/07/17 08:58:25, Yury Semikhatsky wrote: > > LGTM, ...
7 years, 5 months ago (2013-07-17 09:03:20 UTC) #4
yurys
7 years, 5 months ago (2013-07-17 09:20:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r15708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698