Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1954853002: When user presses Ctrl-N, we should use the current active window's profile to determine on which p… (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When user presses Ctrl-N, we should use the current active window's profile to determine on which profile we should open a new window. BUG=608840 Committed: https://crrev.com/ffeee4dcafd17d3658c3c659cf93aa49dcc90da8 Cr-Commit-Position: refs/heads/master@{#392414}

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 4

Patch Set 3 : Address oshima@'s comments #

Patch Set 4 : Use original profile. #

Patch Set 5 : Fix failed browsertest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1 line) Patch
M chrome/browser/ui/ash/chrome_new_window_delegate.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
A chrome/browser/ui/ash/chrome_new_window_delegate_browsertest.cc View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
xdai1
oshima@, could you help review this CL please? Thanks!
4 years, 7 months ago (2016-05-05 21:09:01 UTC) #2
oshima
can you add a test?
4 years, 7 months ago (2016-05-05 21:38:12 UTC) #3
oshima
can you add a test?
4 years, 7 months ago (2016-05-05 21:38:12 UTC) #4
xdai1
Test added. Please take another look, thanks!
4 years, 7 months ago (2016-05-06 18:31:24 UTC) #5
oshima
https://codereview.chromium.org/1954853002/diff/20001/chrome/browser/ui/ash/chrome_new_window_delegate.cc File chrome/browser/ui/ash/chrome_new_window_delegate.cc (right): https://codereview.chromium.org/1954853002/diff/20001/chrome/browser/ui/ash/chrome_new_window_delegate.cc#newcode105 chrome/browser/ui/ash/chrome_new_window_delegate.cc:105: profile = ProfileManager::GetActiveUserProfile(); optional: conditional operator? https://codereview.chromium.org/1954853002/diff/20001/chrome/browser/ui/ash/chrome_new_window_delegate_browsertest.cc File chrome/browser/ui/ash/chrome_new_window_delegate_browsertest.cc ...
4 years, 7 months ago (2016-05-06 18:44:14 UTC) #6
xdai1
oshima@, I've addressed the comments. Please take another look, thanks! https://codereview.chromium.org/1954853002/diff/20001/chrome/browser/ui/ash/chrome_new_window_delegate.cc File chrome/browser/ui/ash/chrome_new_window_delegate.cc (right): https://codereview.chromium.org/1954853002/diff/20001/chrome/browser/ui/ash/chrome_new_window_delegate.cc#newcode105 ...
4 years, 7 months ago (2016-05-06 20:25:33 UTC) #7
oshima
lgtm thanks!
4 years, 7 months ago (2016-05-06 20:53:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954853002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954853002/160001
4 years, 7 months ago (2016-05-09 19:39:29 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:160001)
4 years, 7 months ago (2016-05-09 20:30:58 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 20:33:02 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ffeee4dcafd17d3658c3c659cf93aa49dcc90da8
Cr-Commit-Position: refs/heads/master@{#392414}

Powered by Google App Engine
This is Rietveld 408576698