Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 1954833003: DocumentThreadableLoader: Add guards for sync notifyFinished() in setResource() (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

DocumentThreadableLoader: Add guards for sync notifyFinished() in setResource() In loadRequest(), setResource() can call clear() synchronously: DocumentThreadableLoader::clear() DocumentThreadableLoader::handleError() Resource::didAddClient() RawResource::didAddClient() and thus |m_client| can be null while resource() isn't null after setResource(), causing crashes (Issue 595964). This CL checks whether |*this| is destructed and whether |m_client| is null after setResource(). BUG=595964 Review-Url: https://codereview.chromium.org/1902683002 Cr-Commit-Position: refs/heads/master@{#391001} (cherry picked from commit 2571533bbb5b554ff47205c8ef1513ccc0817c3e) Committed: https://chromium.googlesource.com/chromium/src/+/4bb31bcd811ff8a7a625f9505cc340d6d4b29bbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
4 years, 7 months ago (2016-05-06 05:41:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4bb31bcd811ff8a7a625f9505cc340d6d4b29bbe.

Powered by Google App Engine
This is Rietveld 408576698