Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1954833002: Add bot_update_lite into recipes (Closed)

Created:
4 years, 7 months ago by hinoka
Modified:
4 years, 3 months ago
Reviewers:
nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add bot_update_lite into recipes This is a lighter version of bot_update. Meant for gradual rollout to one builder at a time via recipes. BUG=587556

Patch Set 1 #

Patch Set 2 : Remove expired args #

Total comments: 1

Patch Set 3 : Breaking it out into a new module #

Total comments: 2

Patch Set 4 : Remove extra file #

Total comments: 2

Patch Set 5 : No force #

Total comments: 1

Patch Set 6 : Also lite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -543 lines) Patch
A + recipe_modules/bot_update_lite/__init__.py View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/bot_update_lite/api.py View 1 2 3 4 6 chunks +6 lines, -13 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.py View 1 2 4 chunks +2 lines, -63 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/basic.json View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/basic_output_manifest.json View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/basic_with_branch_heads.json View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/clobber.json View 1 2 1 chunk +1 line, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/gerrit_no_reset.json View 1 2 1 chunk +1 line, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/no_shallow.json View 1 2 1 chunk +1 line, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/reset_root_solution_revision.json View 1 2 1 chunk +1 line, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/trychange.json View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/trychange_oauth2.json View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob.json View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_fail.json View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_fail_patch.json View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_fail_patch_download.json View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_gerrit_angle.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_v8.json View 1 2 1 chunk +6 lines, -9 lines 0 comments Download
A + recipe_modules/bot_update_lite/example.expected/tryjob_v8_head_by_default.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + recipe_modules/bot_update_lite/resources/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_modules/bot_update_lite/resources/bot_update.py View 1 2 3 4 24 chunks +16 lines, -359 lines 0 comments Download
A + recipe_modules/bot_update_lite/test_api.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
hinoka
as discussed, ptal! My first test will be on https://uberchromegw.corp.google.com/i/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp Since i created that builder ...
4 years, 7 months ago (2016-05-05 20:36:48 UTC) #2
hinoka
Actually gonna split this out into a separate module to allow breaking out some bot_update ...
4 years, 7 months ago (2016-05-05 20:52:31 UTC) #3
hinoka
Ok it's broken out into a new module instead now, ptal.
4 years, 7 months ago (2016-05-05 20:57:45 UTC) #5
iannucci
https://codereview.chromium.org/1954833002/diff/40001/recipe_modules/bot_update/example.expected/basic_lite.json File recipe_modules/bot_update/example.expected/basic_lite.json (right): https://codereview.chromium.org/1954833002/diff/40001/recipe_modules/bot_update/example.expected/basic_lite.json#newcode6 recipe_modules/bot_update/example.expected/basic_lite.json:6: "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update_lite.py", y u has?
4 years, 7 months ago (2016-05-05 21:00:43 UTC) #6
Ryan Tseng
https://codereview.chromium.org/1954833002/diff/40001/recipe_modules/bot_update/example.expected/basic_lite.json File recipe_modules/bot_update/example.expected/basic_lite.json (right): https://codereview.chromium.org/1954833002/diff/40001/recipe_modules/bot_update/example.expected/basic_lite.json#newcode6 recipe_modules/bot_update/example.expected/basic_lite.json:6: "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update_lite.py", On 2016/05/05 21:00:42, iannucci wrote: > y u ...
4 years, 7 months ago (2016-05-05 21:01:48 UTC) #8
hinoka
+nodir
4 years, 6 months ago (2016-05-27 20:23:59 UTC) #10
nodir
https://codereview.chromium.org/1954833002/diff/60001/recipe_modules/bot_update_lite/api.py File recipe_modules/bot_update_lite/api.py (right): https://codereview.chromium.org/1954833002/diff/60001/recipe_modules/bot_update_lite/api.py#newcode194 recipe_modules/bot_update_lite/api.py:194: if force and not self._lite: let's remove force and ...
4 years, 6 months ago (2016-05-27 21:09:19 UTC) #11
hinoka
https://codereview.chromium.org/1954833002/diff/60001/recipe_modules/bot_update_lite/api.py File recipe_modules/bot_update_lite/api.py (right): https://codereview.chromium.org/1954833002/diff/60001/recipe_modules/bot_update_lite/api.py#newcode194 recipe_modules/bot_update_lite/api.py:194: if force and not self._lite: On 2016/05/27 21:09:18, nodir ...
4 years, 6 months ago (2016-05-27 21:13:44 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954833002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954833002/80001
4 years, 6 months ago (2016-05-27 21:13:47 UTC) #14
nodir
lgtm % comment https://codereview.chromium.org/1954833002/diff/80001/recipe_modules/bot_update_lite/__init__.py File recipe_modules/bot_update_lite/__init__.py (right): https://codereview.chromium.org/1954833002/diff/80001/recipe_modules/bot_update_lite/__init__.py#newcode32 recipe_modules/bot_update_lite/__init__.py:32: 'lite': Property(default=False, kind=bool), remove from here ...
4 years, 6 months ago (2016-05-27 21:17:28 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954833002/100001
4 years, 6 months ago (2016-05-27 21:18:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954833002/100001
4 years, 6 months ago (2016-05-27 21:18:38 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:24:49 UTC) #23 
Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

Powered by Google App Engine
This is Rietveld 408576698