Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1954823002: Remove WebFormElement::getNamedElements. (Closed)

Created:
4 years, 7 months ago by esprehn
Modified:
4 years, 7 months ago
Reviewers:
dglazkov
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebFormElement::getNamedElements. Nothing uses it. Committed: https://crrev.com/8214149ca4a39fb54b28e80536aa91edc6ec11ae Cr-Commit-Position: refs/heads/master@{#392031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebFormElement.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954823002/1
4 years, 7 months ago (2016-05-05 20:01:36 UTC) #2
esprehn
4 years, 7 months ago (2016-05-05 20:17:11 UTC) #4
dglazkov
lgtm
4 years, 7 months ago (2016-05-05 20:17:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954823002/1
4 years, 7 months ago (2016-05-05 20:47:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/217035)
4 years, 7 months ago (2016-05-06 04:42:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954823002/1
4 years, 7 months ago (2016-05-06 10:00:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 10:57:01 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 10:58:24 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8214149ca4a39fb54b28e80536aa91edc6ec11ae
Cr-Commit-Position: refs/heads/master@{#392031}

Powered by Google App Engine
This is Rietveld 408576698