Issue 19548: Fix some of the most egregious problems with Aero glass frames. These change...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19548: Fix some of the most egregious problems with Aero glass frames. These change... (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix some of the most egregious problems with Aero glass frames. These changes are basically hacks, but they're hacks that get our frame width, tabstrip layout (in non-OTR mode), and client edge drawing to exactly match pre-Magic-BrowzR code. In subsequent changes I will clean this all up to work better. This also fixes windows refusing to become activated. BUG=5054, 6174 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9062

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	chrome/browser/views/frame/aero_glass_frame.cc	View		4 chunks	+16 lines, -13 lines	0 comments	Download
	M	chrome/browser/views/frame/aero_glass_non_client_view.cc	View	1	3 chunks	+14 lines, -17 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

11 years, 10 months ago (2009-02-03 01:30:01 UTC) #2

LGTM, one RFC

http://codereview.chromium.org/19548/diff/7/203
File chrome/browser/views/frame/aero_glass_non_client_view.cc (right):

http://codereview.chromium.org/19548/diff/7/203#newcode148
Line 148: frame_->IsMaximized() ? (CalculateNonClientTopHeight() - 2) :
kTabStripY;
Could you describe what the '2' is?

Expand Messages | Collapse Messages