Resolve macro redefinition warnings when built in Chromium

Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".

For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.

Committed: https://pdfium.googlesource.com/pdfium/+/d29882d3a0567e297756f69b77562ed4892f012a

[Wei Li, 2016-05-05 18:45:27]

Description was changed from

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine before compiling libtiff
code.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. In addition, our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".
==========

to

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".
==========

[Wei Li, 2016-05-05 18:46:59]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-05 18:47:15]

for review, thanks

[dsinclair, 2016-05-05 18:55:51]

Does this only effect GYP or do we need to update GN as well?

[Wei Li, 2016-05-05 19:24:20]

On 2016/05/05 18:55:51, OOO until May 16 (dsinclair) wrote:
> Does this only effect GYP or do we need to update GN as well?

I am working on GN build now. Will update.

[Wei Li, 2016-05-05 19:40:05]

On 2016/05/05 19:24:20, Wei Li wrote:
> On 2016/05/05 18:55:51, OOO until May 16 (dsinclair) wrote:
> > Does this only effect GYP or do we need to update GN as well?
> 
> I am working on GN build now. Will update.

Done.

[Wei Li, 2016-05-05 19:41:22]

Description was changed from

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".
==========

to

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".

For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.
==========

[Tom Sepez, 2016-05-05 19:59:29]

lgtm

[Tom Sepez, 2016-05-05 19:59:30]

lgtm

lgtm

[dsinclair, 2016-05-06 00:01:21]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-06 00:01:21]

lgtm

[commit-bot: I haz the power, 2016-05-06 00:01:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954773002/20001

[commit-bot: I haz the power, 2016-05-06 00:13:48]

Description was changed from

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".

For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.
==========

to

==========
Resolve macro redefinition warnings when built in Chromium

Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.

Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.

After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".

For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.

Committed:
https://pdfium.googlesource.com/pdfium/+/d29882d3a0567e297756f69b77562ed4892f...
==========

[commit-bot: I haz the power, 2016-05-06 00:13:49]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d29882d3a0567e297756f69b77562ed4892f...