Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1954763003: Merge "print_preview: Workaround of focus-scroll issue." to M51 (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge "print_preview: Workaround of focus-scroll issue." to M51 * Make margin-control-textbox elements unfocusable if not in custom margin mode. * Reset the scroll position of preview-area when margin-control-textbox is focused. BUG=601341 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1917413002 Cr-Commit-Position: refs/heads/master@{#390902} (cherry picked from commit dedbae45b850e09e8de724bc678cbec27a7ed6c8) Committed: https://chromium.googlesource.com/chromium/src/+/9e9ef8f9049d13aea9310d16ecc145b24becbc3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/resources/print_preview/previewarea/margin_control.js View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 7 months ago (2016-05-05 23:24:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e9ef8f9049d13aea9310d16ecc145b24becbc3b.

Powered by Google App Engine
This is Rietveld 408576698