Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1954753002: device_sensors: make sure to clear the shared memory buffer on each start. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, timvolodine, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

device_sensors: make sure to clear the shared memory buffer on each start. DataFetcherSharedMemoryBase::StartFetchingDeviceData(ConsumerType) should clear the shared memory buffer before each start to make sure there are no stale values. This patch adds robustness to platform dependent fetcher implementations e.g. when the buffer is live and its data is updated incrementally as soon as it becomes available. It also allows to correctly handle cases when sensors are disabled or go offline. BUG=609533 Committed: https://crrev.com/9b8b3e34a3251fba6019857b1299e0bae7892662 Cr-Commit-Position: refs/heads/master@{#392386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 3 chunks +27 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
timvolodine
4 years, 7 months ago (2016-05-05 17:57:32 UTC) #4
Michael van Ouwerkerk
lgtm
4 years, 7 months ago (2016-05-09 12:34:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954753002/1
4 years, 7 months ago (2016-05-09 18:09:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 18:58:55 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 19:00:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b8b3e34a3251fba6019857b1299e0bae7892662
Cr-Commit-Position: refs/heads/master@{#392386}

Powered by Google App Engine
This is Rietveld 408576698