Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: Source/core/html/shadow/MediaControlElements.h

Issue 195473002: Let MediaControls use the parent HTMLMediaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/MediaControlElements.h
diff --git a/Source/core/html/shadow/MediaControlElements.h b/Source/core/html/shadow/MediaControlElements.h
index 49c6aa2312f86d4c35e3bd11ffd493d502442fd9..bb90bd407e62ec1a32e6df8fce03ade960b7500b 100644
--- a/Source/core/html/shadow/MediaControlElements.h
+++ b/Source/core/html/shadow/MediaControlElements.h
@@ -38,7 +38,7 @@ namespace WebCore {
class MediaControlPanelElement FINAL : public MediaControlDivElement {
public:
- static PassRefPtr<MediaControlPanelElement> create(Document&);
+ static PassRefPtr<MediaControlPanelElement> create(HTMLMediaElement&);
void setCanBeDragged(bool);
void setIsDisplayed(bool);
@@ -51,7 +51,7 @@ public:
virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
private:
- explicit MediaControlPanelElement(Document&);
+ explicit MediaControlPanelElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -80,10 +80,10 @@ private:
class MediaControlPanelEnclosureElement FINAL : public MediaControlDivElement {
public:
- static PassRefPtr<MediaControlPanelEnclosureElement> create(Document&);
+ static PassRefPtr<MediaControlPanelEnclosureElement> create(HTMLMediaElement&);
private:
- explicit MediaControlPanelEnclosureElement(Document&);
+ explicit MediaControlPanelEnclosureElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
};
@@ -91,10 +91,10 @@ private:
class MediaControlOverlayEnclosureElement FINAL : public MediaControlDivElement {
public:
- static PassRefPtr<MediaControlOverlayEnclosureElement> create(Document&);
+ static PassRefPtr<MediaControlOverlayEnclosureElement> create(HTMLMediaElement&);
private:
- explicit MediaControlOverlayEnclosureElement(Document&);
+ explicit MediaControlOverlayEnclosureElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
};
@@ -102,13 +102,13 @@ private:
class MediaControlMuteButtonElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlMuteButtonElement> create(Document&);
+ static PassRefPtr<MediaControlMuteButtonElement> create(HTMLMediaElement&);
virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
virtual void updateDisplayType() OVERRIDE;
private:
- explicit MediaControlMuteButtonElement(Document&);
+ explicit MediaControlMuteButtonElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -118,13 +118,13 @@ private:
class MediaControlPlayButtonElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlPlayButtonElement> create(Document&);
+ static PassRefPtr<MediaControlPlayButtonElement> create(HTMLMediaElement&);
virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
virtual void updateDisplayType() OVERRIDE;
private:
- explicit MediaControlPlayButtonElement(Document&);
+ explicit MediaControlPlayButtonElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -134,12 +134,12 @@ private:
class MediaControlOverlayPlayButtonElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlOverlayPlayButtonElement> create(Document&);
+ static PassRefPtr<MediaControlOverlayPlayButtonElement> create(HTMLMediaElement&);
virtual void updateDisplayType() OVERRIDE;
private:
- explicit MediaControlOverlayPlayButtonElement(Document&);
+ explicit MediaControlOverlayPlayButtonElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -149,14 +149,14 @@ private:
class MediaControlToggleClosedCaptionsButtonElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlToggleClosedCaptionsButtonElement> create(Document&);
+ static PassRefPtr<MediaControlToggleClosedCaptionsButtonElement> create(HTMLMediaElement&);
virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
virtual void updateDisplayType() OVERRIDE;
private:
- explicit MediaControlToggleClosedCaptionsButtonElement(Document&);
+ explicit MediaControlToggleClosedCaptionsButtonElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -166,7 +166,7 @@ private:
class MediaControlTimelineElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlTimelineElement> create(Document&, MediaControls*);
+ static PassRefPtr<MediaControlTimelineElement> create(HTMLMediaElement&, MediaControls*);
virtual bool willRespondToMouseClickEvents() OVERRIDE;
@@ -174,7 +174,7 @@ public:
void setDuration(double);
private:
- explicit MediaControlTimelineElement(Document&, MediaControls*);
+ explicit MediaControlTimelineElement(HTMLMediaElement&, MediaControls*);
acolwell GONE FROM CHROMIUM 2014/03/12 00:22:32 nit: drop explicit
philipj_slow 2014/03/12 04:30:11 Done.
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -186,14 +186,14 @@ private:
class MediaControlFullscreenButtonElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlFullscreenButtonElement> create(Document&);
+ static PassRefPtr<MediaControlFullscreenButtonElement> create(HTMLMediaElement&);
virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
void setIsFullscreen(bool);
private:
- explicit MediaControlFullscreenButtonElement(Document&);
+ explicit MediaControlFullscreenButtonElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -203,14 +203,14 @@ private:
class MediaControlVolumeSliderElement FINAL : public MediaControlInputElement {
public:
- static PassRefPtr<MediaControlVolumeSliderElement> create(Document&);
+ static PassRefPtr<MediaControlVolumeSliderElement> create(HTMLMediaElement&);
virtual bool willRespondToMouseMoveEvents() OVERRIDE;
virtual bool willRespondToMouseClickEvents() OVERRIDE;
void setVolume(double);
private:
- explicit MediaControlVolumeSliderElement(Document&);
+ explicit MediaControlVolumeSliderElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual void defaultEventHandler(Event*) OVERRIDE;
@@ -220,10 +220,10 @@ private:
class MediaControlTimeRemainingDisplayElement FINAL : public MediaControlTimeDisplayElement {
public:
- static PassRefPtr<MediaControlTimeRemainingDisplayElement> create(Document&);
+ static PassRefPtr<MediaControlTimeRemainingDisplayElement> create(HTMLMediaElement&);
private:
- explicit MediaControlTimeRemainingDisplayElement(Document&);
+ explicit MediaControlTimeRemainingDisplayElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
};
@@ -231,10 +231,10 @@ private:
class MediaControlCurrentTimeDisplayElement FINAL : public MediaControlTimeDisplayElement {
public:
- static PassRefPtr<MediaControlCurrentTimeDisplayElement> create(Document&);
+ static PassRefPtr<MediaControlCurrentTimeDisplayElement> create(HTMLMediaElement&);
private:
- explicit MediaControlCurrentTimeDisplayElement(Document&);
+ explicit MediaControlCurrentTimeDisplayElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
};
@@ -242,14 +242,14 @@ private:
class MediaControlTextTrackContainerElement FINAL : public MediaControlDivElement {
public:
- static PassRefPtr<MediaControlTextTrackContainerElement> create(Document&);
+ static PassRefPtr<MediaControlTextTrackContainerElement> create(HTMLMediaElement&);
void updateDisplay();
void updateSizes();
static const AtomicString& textTrackContainerElementShadowPseudoId();
private:
- explicit MediaControlTextTrackContainerElement(Document&);
+ explicit MediaControlTextTrackContainerElement(HTMLMediaElement&);
virtual const AtomicString& shadowPseudoId() const OVERRIDE;
virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698