chrome/common_constants.gyp - Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common_constants.gyp

Issue 19547009: Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: gyp too Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | chrome/installer/setup/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common_constants.gyp

diff --git a/chrome/common_constants.gyp b/chrome/common_constants.gyp

index b0ee2cdec5876b574a922a677aaf300e7f57d29b..bf405264ac351457258b39e5a09a2d7703ab3514 100644

--- a/chrome/common_constants.gyp

+++ b/chrome/common_constants.gyp

@@ -13,6 +13,8 @@

'target_defaults': {

'sources': [

+ '../extensions/common/constants.cc',

gab 2013/07/23 19:38:15 Add a TODO to move this to an 'extension_constants

+ '../extensions/common/constants.h',

'common/chrome_constants.cc',

'common/chrome_constants.h',

'common/chrome_paths.cc',

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc ('k') | chrome/installer/setup/DEPS » ('j') | no next file with comments »