Move ".crx"/".pem" constants and extension_filenames constants into extensions/common/constants.cc.

chrome/utility/extensions/unpacker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/utility/extensions/unpacker.h"
+#include "extensions/common/constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace errors = extension_manifest_errors;
-namespace filenames = extension_filenames;
 namespace keys = extension_manifest_keys;
 
 namespace extensions {
 
 class UnpackerTest : public testing::Test {
 public:
   virtual ~UnpackerTest() {
     LOG(WARNING) << "Deleting temp dir: "
                  << temp_dir_.path().LossyDisplayName();
     LOG(WARNING) << temp_dir_.Delete();
@@ skipping 96 matching lines @@
   SetupUnpacker("no_l10n.crx");
   EXPECT_TRUE(unpacker_->Run());
   EXPECT_TRUE(unpacker_->error_message().empty());
   EXPECT_EQ(0U, unpacker_->parsed_catalogs()->size());
 }
 
 TEST_F(UnpackerTest, UnzipDirectoryError) {
   const char* kExpected = "Could not create directory for unzipping: ";
   SetupUnpacker("good_package.crx");
   base::FilePath path =
-      temp_dir_.path().AppendASCII(filenames::kTempExtensionName);
+      temp_dir_.path().AppendASCII(kTempExtensionName);
   ASSERT_TRUE(file_util::WriteFile(path, "foo", 3));
   EXPECT_FALSE(unpacker_->Run());
   EXPECT_TRUE(StartsWith(unpacker_->error_message(),
               ASCIIToUTF16(kExpected),
               false)) << "Expected prefix: \"" << kExpected
                       << "\", actual error: \"" << unpacker_->error_message()
                       << "\"";
 }
 
 TEST_F(UnpackerTest, UnzipError) {
@@ skipping 20 matching lines @@
   SetupUnpacker("bad_image.crx");
   EXPECT_FALSE(unpacker_->Run());
   EXPECT_TRUE(StartsWith(unpacker_->error_message(),
               ASCIIToUTF16(kExpected),
               false)) << "Expected prefix: \"" << kExpected
                       << "\", actual error: \"" << unpacker_->error_message()
                       << "\"";
 }
 
 }  // namespace extensions