Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1954693002: Deprecate subscriptions to MediaStream ended event (Closed)

Created:
4 years, 7 months ago by Guido Urdaneta
Modified:
4 years, 7 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org, hta - Chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate subscriptions to MediaStream ended event including those made with addEventListener. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EHy8zm0eVy0 BUG=608795 Committed: https://crrev.com/fcbbc1cb8bb9ce60e7bb29a7f1aff02f06be412d Cr-Commit-Position: refs/heads/master@{#392232}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rbyers comments + deprecation #

Patch Set 3 : Fix expected output from test #

Patch Set 4 : Improve deprecation message #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
Guido Urdaneta
Hi, PTAL
4 years, 7 months ago (2016-05-05 10:45:00 UTC) #4
Rick Byers
LGTM with nit You're going to also turn this into a deprecation (instead of just ...
4 years, 7 months ago (2016-05-05 14:08:58 UTC) #7
Guido Urdaneta
Hi, I turned this CL into the deprecation CL. PTAL.
4 years, 7 months ago (2016-05-06 12:49:49 UTC) #9
Rick Byers
LGTM
4 years, 7 months ago (2016-05-06 17:54:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954693002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954693002/80001
4 years, 7 months ago (2016-05-06 18:09:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/133519) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-06 18:20:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954693002/100001
4 years, 7 months ago (2016-05-06 19:00:07 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/217639)
4 years, 7 months ago (2016-05-06 22:00:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954693002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954693002/100001
4 years, 7 months ago (2016-05-06 22:19:46 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-07 01:49:11 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 01:50:25 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fcbbc1cb8bb9ce60e7bb29a7f1aff02f06be412d
Cr-Commit-Position: refs/heads/master@{#392232}

Powered by Google App Engine
This is Rietveld 408576698