Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1954673002:
Make ImageDecodeBench build again (Closed)
|
Created:
4 years, 7 months ago by Noel Gordon Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews, kinuko+watch Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ImageDecodeBench build again
Remove unnecessary windows #error re LEAN_AND_MEAN, including
<mmsystem.h> is enough.
Use size_t instead of position for SharedBuffer::getSomeData.
Call base::CommandLine::Init() to avoid a SEGFAULT at start-up
when Platform heap initializes and trys to read CommmandLine.
Inherit from blink::Platform, not TestingPlatformSupport.
Remove missing function from ImageDecoder. Instead, decode once
before the bench loop to initialize Platform statics.
Build: move the gyp into blink_platform_tests.gyp and the .cpp
to platform/testing to allow the call to base::CommandLine per
the rules in platform/testing/DEPS.
This patch is based on previous patch by scroggo@chromium.org,
refer to https://codereview.chromium.org/1879133002
TBR=jochen@chromium.org
BUG=601198
Committed: https://crrev.com/cab42628d6fe53b18f9d119d3999746c79b33ba5
Cr-Commit-Position: refs/heads/master@{#391831}
Patch Set 1 #Patch Set 2 : Fix linux_chromium_rel_ng nit. #1 #Patch Set 3 : Fix linux_chromium_rel_ng nit. #2 #
Total comments: 1
Patch Set 4 : Move ImageDecodeBench.cpp to platform/testing. #
Messages
Total messages: 34 (16 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/40001
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/60001
Patchset #4 (id:60001) has been deleted
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/80001
https://codereview.chromium.org/1954673002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-decoders/ImageDecodeBench.cpp (right): https://codereview.chromium.org/1954673002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-decoders/ImageDecodeBench.cpp:25: #include <base/command_line.h> Using <base/command_line.h> defeats the DEPS check: there is no DEPS in directory image-decoders to check against. That's not really in the spirit of things, so we should move this .cpp into a directory that has a DEPS file, platform/testing say.
On 2016/05/05 13:25:55, noel gordon wrote: > That's not really in the spirit of things, so we should move this .cpp into a > directory that has a DEPS file, platform/testing say. https://codereview.chromium.org/1954673002/#ps80001
Description was changed from ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform instead of TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move into blink_platform_tests.gyp to allow the call to base::CommandLine. BUG=601198 ========== to ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine. BUG=601198 ==========
Description was changed from ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine. BUG=601198 ========== to ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. BUG=601198 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/05/05 13:56:28, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. leon@ could you look at the ImageDecodeBench.cpp changes. jochen@ for Source/web changes.
noel@chromium.org changed reviewers: + jochen@chromium.org, scroggo@chromium.org
lgtm
Description was changed from ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. BUG=601198 ========== to ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. This patch is based on previous patch by scroggo@chromium.org, refer to https://codereview.chromium.org/1879133002 TBR=jochen@chromium.org BUG=601198 ==========
Thanks for helping with this Leon, attribution added to the change description. Pretty sure jochen@ won't mind us removing code from Source/web :) TBR, jochen@, please squeak if you have any concerns.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954673002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954673002/80001
Message was sent while issue was closed.
Description was changed from ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. This patch is based on previous patch by scroggo@chromium.org, refer to https://codereview.chromium.org/1879133002 TBR=jochen@chromium.org BUG=601198 ========== to ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. This patch is based on previous patch by scroggo@chromium.org, refer to https://codereview.chromium.org/1879133002 TBR=jochen@chromium.org BUG=601198 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. This patch is based on previous patch by scroggo@chromium.org, refer to https://codereview.chromium.org/1879133002 TBR=jochen@chromium.org BUG=601198 ========== to ========== Make ImageDecodeBench build again Remove unnecessary windows #error re LEAN_AND_MEAN, including <mmsystem.h> is enough. Use size_t instead of position for SharedBuffer::getSomeData. Call base::CommandLine::Init() to avoid a SEGFAULT at start-up when Platform heap initializes and trys to read CommmandLine. Inherit from blink::Platform, not TestingPlatformSupport. Remove missing function from ImageDecoder. Instead, decode once before the bench loop to initialize Platform statics. Build: move the gyp into blink_platform_tests.gyp and the .cpp to platform/testing to allow the call to base::CommandLine per the rules in platform/testing/DEPS. This patch is based on previous patch by scroggo@chromium.org, refer to https://codereview.chromium.org/1879133002 TBR=jochen@chromium.org BUG=601198 Committed: https://crrev.com/cab42628d6fe53b18f9d119d3999746c79b33ba5 Cr-Commit-Position: refs/heads/master@{#391831} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/cab42628d6fe53b18f9d119d3999746c79b33ba5 Cr-Commit-Position: refs/heads/master@{#391831} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
