device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc - Issue 1954643002: DBus support for attribute properties and permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

Issue 1954643002: DBus support for attribute properties and permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@register_and_events

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.h ('k') | device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_service_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

diff --git a/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc b/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

index d30a9e059bc036adccfec08df3797eced37ad925..db228aa72080d56a16ff1735ce986b508d9b188a 100644

--- a/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

+++ b/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc

@@ -18,7 +18,6 @@ FakeBluetoothGattCharacteristicServiceProvider::

std::unique_ptr<BluetoothGattAttributeValueDelegate> delegate,

const std::string& uuid,

const std::vector<std::string>& flags,

- const std::vector<std::string>& permissions,

const dbus::ObjectPath& service_path)

: object_path_(object_path),

uuid_(uuid),

@@ -33,7 +32,7 @@ FakeBluetoothGattCharacteristicServiceProvider::

DCHECK(base::StartsWith(object_path_.value(), service_path_.value() + "/",

base::CompareCase::SENSITIVE));

- // TODO(armansito): Do something with |flags| and |permissions|.

+ // TODO(rkc): Do something with |flags|.

FakeBluetoothGattManagerClient* fake_bluetooth_gatt_manager_client =

static_cast<FakeBluetoothGattManagerClient*>(

bluez::BluezDBusManager::Get()->GetBluetoothGattManagerClient());