device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h - Issue 1954643002: DBus support for attribute properties and permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

Issue 1954643002: DBus support for attribute properties and permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@register_and_events

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

diff --git a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

index 80a2b7d9d67a438bcb5a4ef6759464f09a1eac5f..af46228cc9fc944d60aab8a09f8cbe266c8095df 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

+++ b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

@@ -50,11 +50,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattCharacteristicServiceProvider {

// Creates the instance, where |bus| is the D-Bus bus connection to export

// the object onto, |uuid| is the 128-bit GATT characteristic UUID,

- // |flags| is the list of GATT characteristic properties, |permissions| is the

- // list of attribute permissions, |service_path| is the object path of the

- // exported GATT service the characteristic belongs to, |object_path| is the

- // object path that the characteristic should have, and |delegate| is the

- // object that "Value" Get/Set requests will be passed to and responses

+ // |flags| is the list of GATT characteristic properties, |flags| is the

+ // list of flags for this characteristic, |service_path| is the object path

+ // of the exported GATT service the characteristic belongs to, |object_path|

+ // is the object path that the characteristic should have, and |delegate| is

+ // the object that "Value" Get/Set requests will be passed to and responses

// generated from.

// Object paths of GATT characteristics must be hierarchical to the path of

@@ -68,7 +68,6 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattCharacteristicServiceProvider {

std::unique_ptr<BluetoothGattAttributeValueDelegate> delegate,

const std::string& uuid,

const std::vector<std::string>& flags,

- const std::vector<std::string>& permissions,

const dbus::ObjectPath& service_path);

protected: