Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1954613002: [Smart Lock] Propagate click on positive button to native counterpart. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Propagate click on positive button to native counterpart. Click on positive button ("Ok, got it") in auto signin first run experience dialog should be propagated to native counterpart. BUG=609135 Committed: https://crrev.com/718778c0679c8ef6e3e2df467eba0fee1d72202c Cr-Commit-Position: refs/heads/master@{#391768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
melandory
PTAL, thanks!
4 years, 7 months ago (2016-05-05 00:07:13 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-05 00:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954613002/1
4 years, 7 months ago (2016-05-05 00:24:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65362)
4 years, 7 months ago (2016-05-05 02:06:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954613002/1
4 years, 7 months ago (2016-05-05 05:33:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 06:03:15 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 06:04:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/718778c0679c8ef6e3e2df467eba0fee1d72202c
Cr-Commit-Position: refs/heads/master@{#391768}

Powered by Google App Engine
This is Rietveld 408576698