Chromium Code Reviews

Issue 1954603002: Move atomic-utils.h into base/ (Closed)

Created:
4 years, 7 months ago by lpy
Modified:
4 years, 7 months ago
Reviewers:
Michael Lippautz, jochen (gone - plz use gerrit)
CC:
Hannes Payer (out of office), Michael Achenbach, ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move atomic-utils.h into base/ atomic-utils.h only uses functionality from base/, and also by moving it into base/, code outside of v8_base can benefit from it. BUG=v8:4991 LOG=n Committed: https://crrev.com/57a73e81c65dc7ed7aaeb2f3c8c08ab9fbe9fba8 Cr-Commit-Position: refs/heads/master@{#36114}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Stats (+37 lines, -429 lines)
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments
D src/atomic-utils.h View 1 chunk +0 lines, -175 lines 0 comments
A + src/base/atomic-utils.h View 2 chunks +2 lines, -2 lines 0 comments
M src/cancelable-task.h View 2 chunks +3 lines, -3 lines 0 comments
M src/heap/heap.h View 2 chunks +3 lines, -3 lines 0 comments
M src/heap/page-parallel-job.h View 1 chunk +1 line, -1 line 0 comments
M src/heap/spaces.h View 5 chunks +13 lines, -13 lines 0 comments
M src/locked-queue-inl.h View 2 chunks +2 lines, -2 lines 0 comments
M src/profiler/cpu-profiler.h View 2 chunks +2 lines, -2 lines 0 comments
M src/profiler/sampler.cc View 5 chunks +5 lines, -5 lines 0 comments
M src/v8.gyp View 2 chunks +1 line, -1 line 0 comments
M test/unittests/atomic-utils-unittest.cc View 1 chunk +0 lines, -217 lines 0 comments
A + test/unittests/base/atomic-utils-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments
M test/unittests/unittests.gyp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 11 (3 generated)
lpy
PTAL.
4 years, 7 months ago (2016-05-04 23:08:19 UTC) #2
Michael Lippautz
Deferring to Jochen. We initially kept it out of base since it had only very ...
4 years, 7 months ago (2016-05-06 08:42:40 UTC) #3
jochen (gone - plz use gerrit)
I think it should have been in base/ from the beginning on :) https://codereview.chromium.org/1954603002/diff/60001/src/base/atomic-utils.h File ...
4 years, 7 months ago (2016-05-06 09:25:52 UTC) #4
lpy
Done. PTAL. https://codereview.chromium.org/1954603002/diff/60001/src/base/atomic-utils.h File src/base/atomic-utils.h (right): https://codereview.chromium.org/1954603002/diff/60001/src/base/atomic-utils.h#newcode14 src/base/atomic-utils.h:14: namespace internal { On 2016/05/06 09:25:52, jochen ...
4 years, 7 months ago (2016-05-06 17:37:55 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-09 15:24:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954603002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954603002/80001
4 years, 7 months ago (2016-05-09 15:40:11 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-09 16:22:16 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 16:24:07 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/57a73e81c65dc7ed7aaeb2f3c8c08ab9fbe9fba8
Cr-Commit-Position: refs/heads/master@{#36114}

Powered by Google App Engine