xfa/fgas/layout/fgas_textbreak.h - Issue 1954593004: CFX_ArabicChar contains only static methods, no need to instantiate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fgas/layout/fgas_textbreak.h

Issue 1954593004: CFX_ArabicChar contains only static methods, no need to instantiate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Replace method with local function. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fgas/layout/fgas_textbreak.h

diff --git a/xfa/fgas/layout/fgas_textbreak.h b/xfa/fgas/layout/fgas_textbreak.h

index 41bd8f4921bade2156bd11fd2703ba5ace2d7ae9..a1ff52e1913129502c2a65866835e7067af700e7 100644

--- a/xfa/fgas/layout/fgas_textbreak.h

+++ b/xfa/fgas/layout/fgas_textbreak.h

@@ -270,7 +270,6 @@ class CFX_TxtBreak {

protected:

uint32_t m_dwPolicies;

FX_BOOL m_bPagination;

- CFX_ArabicChar* m_pArabicChar;

int32_t m_iLineWidth;

uint32_t m_dwLayoutStyles;

FX_BOOL m_bVertical;

« core/fxcrt/include/fx_arabic.h ('K') | « xfa/fgas/layout/fgas_rtfbreak.cpp ('k') | xfa/fgas/layout/fgas_textbreak.cpp » ('j') | no next file with comments »