Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3286)

Unified Diff: core/fxcrt/include/fx_arabic.h

Issue 1954593004: CFX_ArabicChar contains only static methods, no need to instantiate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Replace method with local function. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/fx_arabic.cpp ('k') | xfa/fgas/layout/fgas_rtfbreak.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/include/fx_arabic.h
diff --git a/core/fxcrt/include/fx_arabic.h b/core/fxcrt/include/fx_arabic.h
index 96fa7954c3de1f15b2c1d248d5729a0f650949aa..120c4012869e89081f0fb1788ad3f34b446b876d 100644
--- a/core/fxcrt/include/fx_arabic.h
+++ b/core/fxcrt/include/fx_arabic.h
@@ -16,22 +16,18 @@
class CFX_ArabicChar {
public:
- void Release() { delete this; }
+ static bool IsArabicChar(FX_WCHAR wch);
+ static bool IsArabicFormChar(FX_WCHAR wch);
- FX_BOOL IsArabicChar(FX_WCHAR wch) const;
- FX_BOOL IsArabicFormChar(FX_WCHAR wch) const;
+ static FX_WCHAR GetFormChar(FX_WCHAR wch,
+ FX_WCHAR prev = 0,
+ FX_WCHAR next = 0);
+ static FX_WCHAR GetFormChar(const CFX_Char* cur,
+ const CFX_Char* prev,
+ const CFX_Char* next);
- FX_WCHAR GetFormChar(FX_WCHAR wch,
- FX_WCHAR prev = 0,
- FX_WCHAR next = 0) const;
- FX_WCHAR GetFormChar(const CFX_Char* cur,
- const CFX_Char* prev,
- const CFX_Char* next) const;
-
- protected:
- const FX_ARBFORMTABLE* ParseChar(const CFX_Char* pTC,
- FX_WCHAR& wChar,
- FX_CHARTYPE& eType) const;
+ private:
+ CFX_ArabicChar() = delete; // Just a namespace !!!
Wei Li 2016/05/06 18:58:28 Looks like namespace is preferred in this case htt
};
void FX_BidiReverseString(CFX_WideString& wsText,
« no previous file with comments | « core/fxcrt/fx_arabic.cpp ('k') | xfa/fgas/layout/fgas_rtfbreak.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698