Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1954593002: Ported telemetry_gpu_test target to Android. (Closed)

Created:
4 years, 7 months ago by cblume
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ported telemetry_gpu_test target to Android. Tested by running the isolate locally. Other targets will be ported in follow-on CLs. BUG=490984 Committed: https://crrev.com/d8e58024517999f14a850ab14d915e280294e03e Cr-Commit-Position: refs/heads/master@{#391743}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Making telemetry_perf_unittests and perf targets test only. #

Patch Set 3 : Making telemetry_unittests test only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -39 lines) Patch
M chrome/test/BUILD.gn View 1 2 4 chunks +35 lines, -32 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/chrome_telemetry_build/BUILD.gn View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 29 (13 generated)
cblume
4 years, 7 months ago (2016-05-04 22:56:56 UTC) #2
Ken Russell (switch to Gerrit)
LGTM++!!!
4 years, 7 months ago (2016-05-04 22:57:18 UTC) #3
Ken Russell (switch to Gerrit)
+more tools/perf owners Note, this has been tested locally.
4 years, 7 months ago (2016-05-04 23:02:42 UTC) #7
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn#newcode38 tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", Note: this dependency was "bitmaptools#host" in the GYP ...
4 years, 7 months ago (2016-05-04 23:04:28 UTC) #8
aiolos (Not reviewing)
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn#newcode38 tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:04:27, Ken Russell wrote: > Note: ...
4 years, 7 months ago (2016-05-04 23:08:56 UTC) #9
Dirk Pranke
lgtm! https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn#newcode38 tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:04:27, Ken Russell wrote: > ...
4 years, 7 months ago (2016-05-04 23:09:11 UTC) #10
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry_build/BUILD.gn#newcode38 tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:08:56, aiolos(slow reviews) wrote: > On ...
4 years, 7 months ago (2016-05-04 23:10:34 UTC) #11
aiolos (Not reviewing)
lgtm
4 years, 7 months ago (2016-05-04 23:10:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/1
4 years, 7 months ago (2016-05-04 23:11:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/132585)
4 years, 7 months ago (2016-05-04 23:22:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/20001
4 years, 7 months ago (2016-05-04 23:39:13 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/132651)
4 years, 7 months ago (2016-05-04 23:51:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/40001
4 years, 7 months ago (2016-05-04 23:53:08 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/40001
4 years, 7 months ago (2016-05-05 02:05:53 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-05 03:24:12 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 03:26:16 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8e58024517999f14a850ab14d915e280294e03e
Cr-Commit-Position: refs/heads/master@{#391743}

Powered by Google App Engine
This is Rietveld 408576698