|
|
Chromium Code Reviews
DescriptionPorted telemetry_gpu_test target to Android.
Tested by running the isolate locally. Other targets will be ported in
follow-on CLs.
BUG=490984
Committed: https://crrev.com/d8e58024517999f14a850ab14d915e280294e03e
Cr-Commit-Position: refs/heads/master@{#391743}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Making telemetry_perf_unittests and perf targets test only. #Patch Set 3 : Making telemetry_unittests test only. #
Messages
Total messages: 29 (13 generated)
cblume@chromium.org changed reviewers: + dpranke@chromium.org, jbudorick@chromium.org, kbr@chromium.org
LGTM++!!!
The CQ bit was checked by cblume@chromium.org
The CQ bit was unchecked by cblume@chromium.org
kbr@chromium.org changed reviewers: + aiolos@chromium.org, dtu@chromium.org
+more tools/perf owners Note, this has been tested locally.
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", Note: this dependency was "bitmaptools#host" in the GYP build; don't know what it needs to be in the GN build.
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:04:27, Ken Russell wrote: > Note: this dependency was "bitmaptools#host" in the GYP build; don't know what > it needs to be in the GN build. I think it should be the following, but could use some verification: "//third_party/catapult/telemetry:bitmaptools($host_toolchain)",
lgtm! https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:04:27, Ken Russell wrote: > Note: this dependency was "bitmaptools#host" in the GYP build; don't know what > it needs to be in the GN build. This should be "//third_party/catapult/telemetry:bitmaptools($host_toolchain)"
https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... File tools/perf/chrome_telemetry_build/BUILD.gn (right): https://codereview.chromium.org/1954593002/diff/1/tools/perf/chrome_telemetry... tools/perf/chrome_telemetry_build/BUILD.gn:38: "//third_party/catapult/telemetry:bitmaptools", On 2016/05/04 23:08:56, aiolos(slow reviews) wrote: > On 2016/05/04 23:04:27, Ken Russell wrote: > > Note: this dependency was "bitmaptools#host" in the GYP build; don't know what > > it needs to be in the GN build. > > I think it should be the following, but could use some verification: > > "//third_party/catapult/telemetry:bitmaptools($host_toolchain)", Thanks! dpranke@ verified below. We'll refactor this in a follow-on CL. Want to get at least the webgl_conformance_tests running on the new bot first.
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by cblume@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org, kbr@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1954593002/#ps20001 (title: "Making telemetry_perf_unittests and perf targets test only.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/20001
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by cblume@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org, kbr@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1954593002/#ps40001 (title: "Making telemetry_unittests test only.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/40001
The CQ bit was unchecked by cblume@chromium.org
The CQ bit was checked by cblume@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954593002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Ported telemetry_gpu_test target to Android. Tested by running the isolate locally. Other targets will be ported in follow-on CLs. BUG=490984 ========== to ========== Ported telemetry_gpu_test target to Android. Tested by running the isolate locally. Other targets will be ported in follow-on CLs. BUG=490984 Committed: https://crrev.com/d8e58024517999f14a850ab14d915e280294e03e Cr-Commit-Position: refs/heads/master@{#391743} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d8e58024517999f14a850ab14d915e280294e03e Cr-Commit-Position: refs/heads/master@{#391743} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
