Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3699)

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc

Issue 1954553002: [Downloads] Use a shorter status string in chrome://downloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
index e2dd721e7ada64593240403c734d6a0fd4a68ec0..5ba1d0a11af334f2f36216ad23ea09e11123bf66 100644
--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
@@ -279,7 +279,11 @@ DownloadsListTracker::CreateDownloadItemValue(
if (download_item->CanResume())
percent = download_item->PercentComplete();
- last_reason_text = download_model.GetInterruptReasonText();
+ // TODO(asanka): last_reason_text should be set via
+ // download_model.GetInterruptReasonText(). But we are using
+ // GetStatusText() as a temporary measure until the layout is fixed to
+ // accommodate the longer string. http://crbug.com/609255
+ last_reason_text = download_model.GetStatusText();
if (content::DOWNLOAD_INTERRUPT_REASON_CRASH ==
download_item->GetLastReason() && !download_item->CanResume()) {
retry = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698