Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: ipc/ipc_channel_win.cc

Issue 1954543002: Remove handler from MessagePumpForIO::IOContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_observers
Patch Set: CR thestig #17 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_win.h ('k') | mojo/edk/system/channel_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_win.cc
diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc
index 404e688a212367303b3d9ccee8eba0a4b1da0957..8bdb7ae33b370cd644431547a4df0de22cb3fc88 100644
--- a/ipc/ipc_channel_win.cc
+++ b/ipc/ipc_channel_win.cc
@@ -28,10 +28,7 @@
namespace IPC {
-ChannelWin::State::State(ChannelWin* channel) : is_pending(false) {
- memset(&context.overlapped, 0, sizeof(context.overlapped));
- context.handler = channel;
-}
+ChannelWin::State::State() = default;
ChannelWin::State::~State() {
static_assert(offsetof(ChannelWin::State, context) == 0,
@@ -43,8 +40,6 @@ ChannelWin::ChannelWin(const IPC::ChannelHandle& channel_handle,
Mode mode,
Listener* listener)
: ChannelReader(listener),
- input_state_(this),
- output_state_(this),
peer_pid_(base::kNullProcessId),
waiting_connect_(mode & MODE_SERVER_FLAG),
processing_incoming_(false),
« no previous file with comments | « ipc/ipc_channel_win.h ('k') | mojo/edk/system/channel_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698