Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1954533002: Implement wouldTaintOrigin and expose createPattern for OCRC2D on main thread (Closed)

Created:
4 years, 7 months ago by xlai (Olivia)
Modified:
4 years, 7 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, haraken, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement wouldTaintOrigin and expose createPattern for OCRC2D on main thread BUG=606925, 563856 Committed: https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015 Cr-Commit-Position: refs/heads/master@{#392139}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Expose createPattern on main #

Patch Set 3 : Added security test #

Patch Set 4 : OCRC2D pattern is working fine in GPU; remove Failure mark in TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern.html View 1 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern-expected.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-createPattern.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/security/cross-origin-OffscreenCanvas2D-createPattern-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
xlai (Olivia)
This patch is a preparation for exposing createPattern and drawImage on main thread.
4 years, 7 months ago (2016-05-04 20:38:54 UTC) #3
Justin Novosad
CL is missing a test. https://codereview.chromium.org/1954533002/diff/20001/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp (right): https://codereview.chromium.org/1954533002/diff/20001/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp#newcode76 third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp:76: if (!!canvas()) { I ...
4 years, 7 months ago (2016-05-05 14:56:16 UTC) #4
xlai (Olivia)
4 years, 7 months ago (2016-05-06 17:40:32 UTC) #7
Justin Novosad
On 2016/05/06 17:40:32, xlai (Olivia) wrote: lgtm
4 years, 7 months ago (2016-05-06 19:18:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954533002/100002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954533002/100002
4 years, 7 months ago (2016-05-06 19:20:20 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:100002)
4 years, 7 months ago (2016-05-06 20:33:01 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 20:34:03 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2eb27cdecc76bc7fc00eba7ed41b35a2b98f0015
Cr-Commit-Position: refs/heads/master@{#392139}

Powered by Google App Engine
This is Rietveld 408576698