Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 1954523002: Refactors StackingController::GetDefaultParent to ash/wm/common (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactors StackingController::GetDefaultParent to ash/wm/common This way I can use it in mus too. I'm not clear that the windowmanager should handle system modals or lock screen stuff. But for the near term we likely need it for sys_ui. BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab Cr-Commit-Position: refs/heads/master@{#391847}

Patch Set 1 #

Patch Set 2 : merge to trunk #

Total comments: 4

Patch Set 3 : feedback #

Patch Set 4 : merge 2 trunk #

Patch Set 5 : update gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -158 lines) Patch
M ash/root_window_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_controller.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M ash/shell_window_ids.h View 1 2 5 chunks +53 lines, -12 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_globals_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/common/ash_wm_common.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A ash/wm/common/container_finder.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ash/wm/common/container_finder.cc View 1 2 1 chunk +110 lines, -0 lines 0 comments Download
M ash/wm/common/wm_globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/common/wm_shell_window_ids.h View 2 chunks +19 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/stacking_controller.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/wm/stacking_controller.cc View 2 chunks +5 lines, -125 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sky
4 years, 7 months ago (2016-05-04 23:41:33 UTC) #1
James Cook
LGTM https://codereview.chromium.org/1954523002/diff/20001/ash/shell_window_ids.h File ash/shell_window_ids.h (right): https://codereview.chromium.org/1954523002/diff/20001/ash/shell_window_ids.h#newcode169 ash/shell_window_ids.h:169: "lock-screen-system-modal between lock-screen status"); nit: "lock-screen and status" ...
4 years, 7 months ago (2016-05-05 02:11:40 UTC) #2
sky
https://codereview.chromium.org/1954523002/diff/20001/ash/shell_window_ids.h File ash/shell_window_ids.h (right): https://codereview.chromium.org/1954523002/diff/20001/ash/shell_window_ids.h#newcode169 ash/shell_window_ids.h:169: "lock-screen-system-modal between lock-screen status"); On 2016/05/05 02:11:39, James Cook ...
4 years, 7 months ago (2016-05-05 15:33:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954523002/60001
4 years, 7 months ago (2016-05-05 15:39:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/165583) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-05 15:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954523002/80001
4 years, 7 months ago (2016-05-05 17:02:48 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-05 18:25:06 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:26:54 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cb51abf81b0437f5768d1b1de48f41d6e8bc1fab
Cr-Commit-Position: refs/heads/master@{#391847}

Powered by Google App Engine
This is Rietveld 408576698