Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: media/blink/multibuffer_data_source.cc

Issue 1954493002: Tweak multibuffer buffering strategy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/multibuffer_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_data_source.cc
diff --git a/media/blink/multibuffer_data_source.cc b/media/blink/multibuffer_data_source.cc
index 4abd3d8d157a1b87e0ce6b5dc01ad3375c8e9beb..065095d1a42934d05e831ad3debd71995f1558a2 100644
--- a/media/blink/multibuffer_data_source.cc
+++ b/media/blink/multibuffer_data_source.cc
@@ -567,16 +567,25 @@ void MultibufferDataSource::UpdateBufferSizes() {
int64_t preload = clamp(kTargetSecondsBufferedAhead * bytes_per_second,
kMinBufferPreload, kMaxBufferPreload);
+ int64_t preload_high = preload + kPreloadHighExtra;
+
+ // Assert that kMaxBufferSize is big enough that the subtraction on the next
+ // line cannot go negative.
+ static_assert(kMaxBufferSize > kMaxBufferPreload + kPreloadHighExtra,
+ "kMaxBufferSize too small to contain preload.");
int64_t back_buffer = clamp(kTargetSecondsBufferedBehind * bytes_per_second,
- kMinBufferPreload, kMaxBufferPreload);
- int64_t pin_forwards = kMaxBufferSize - back_buffer;
- DCHECK_LE(preload + kPreloadHighExtra, pin_forwards);
- reader_->SetMaxBuffer(back_buffer, preload + kPreloadHighExtra);
+ kMinBufferPreload, kMaxBufferSize - preload_high);
+ int64_t buffer_size =
+ std::min((kTargetSecondsBufferedAhead + kTargetSecondsBufferedBehind) *
+ bytes_per_second,
+ kMaxBufferSize);
+ reader_->SetMaxBuffer(buffer_size);
+ reader_->SetPinRange(back_buffer, kMaxBufferPreload + kPreloadHighExtra);
if (preload_ == METADATA) {
reader_->SetPreload(0, 0);
} else {
- reader_->SetPreload(preload + kPreloadHighExtra, preload);
+ reader_->SetPreload(preload_high, preload);
}
}
« no previous file with comments | « no previous file | media/blink/multibuffer_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698