Skip the SAML confirm password screen when a single password is scraped

Skip the SAML confirm password screen when a single password is scraped

When the SAML handler scrapes exactly a single password, we verify it and
complete the authentication and login. This shaves off one extra password
the user has to type.

BUG=604309
TEST=browser_tests --gtest_filter=(SamlTest|SAMLEnrollmentTest|SAMLPolicyTest).*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f20568fcd6d73c9468b359f2ccd043c257e3c53b
Cr-Commit-Position: refs/heads/master@{#391646}

[afakhry, 2016-05-04 18:52:39]

Description was changed from

==========
Skip the SAML confirm password screen when a single password is scraped

When the SAML handler scrapes exactly a single password, we verify it and
complete the authentication and login. This shaves off one extra password
the user has to type.

BUG=604309
TEST=browser_tests --gtest_filter=(SamlTest|SAMLEnrollmentTest|SAMLPolicyTest).*
==========

to

==========
Skip the SAML confirm password screen when a single password is scraped

When the SAML handler scrapes exactly a single password, we verify it and
complete the authentication and login. This shaves off one extra password
the user has to type.

BUG=604309
TEST=browser_tests --gtest_filter=(SamlTest|SAMLEnrollmentTest|SAMLPolicyTest).*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2016-05-04 18:56:59]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-05-04 18:56:59]

Xiyuan, could you please take a look? Thanks!

[xiyuan, 2016-05-04 19:35:04]

https://codereview.chromium.org/1954453002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1954453002/diff/20001/chrome/browser/resource...
chrome/browser/resources/gaia_auth_host/authenticator.js:657:
this.verifyConfirmedPassword(passwords[0]);
getConsolidatedScrapedPasswords_ is private and we should not call it. And
calling verifyConfirmedPassword is unnecessary. Let's just get the password and
finish the flow here.

Add a getter to saml handler, e.g.
  get firstScrapedPassword() {
    var scraped = this.getConsolidatedScrapedPasswords_();
    return scraped.length ? scraped[0] : '';
  }

then we just get that and finish the flow here:
  this.password_ = this.samlHandler_.firstScrapedPassword();
  this.onAuthCompleted_();

[afakhry, 2016-05-04 20:16:15]

https://codereview.chromium.org/1954453002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1954453002/diff/20001/chrome/browser/resource...
chrome/browser/resources/gaia_auth_host/authenticator.js:657:
this.verifyConfirmedPassword(passwords[0]);
On 2016/05/04 19:35:04, xiyuan wrote:
> getConsolidatedScrapedPasswords_ is private and we should not call it. And
> calling verifyConfirmedPassword is unnecessary. Let's just get the password
and
> finish the flow here.
> 
> Add a getter to saml handler, e.g.
>   get firstScrapedPassword() {
>     var scraped = this.getConsolidatedScrapedPasswords_();
>     return scraped.length ? scraped[0] : '';
>   }
> 
> then we just get that and finish the flow here:
>   this.password_ = this.samlHandler_.firstScrapedPassword();
>   this.onAuthCompleted_();

Done.

[xiyuan, 2016-05-04 20:24:36]

lgtm

Thank you for taking care of this.

[afakhry, 2016-05-04 20:41:21]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-05-04 20:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954453002/40001

[commit-bot: I haz the power, 2016-05-04 21:26:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-04 21:27:46]

Description was changed from

==========
Skip the SAML confirm password screen when a single password is scraped

When the SAML handler scrapes exactly a single password, we verify it and
complete the authentication and login. This shaves off one extra password
the user has to type.

BUG=604309
TEST=browser_tests --gtest_filter=(SamlTest|SAMLEnrollmentTest|SAMLPolicyTest).*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Skip the SAML confirm password screen when a single password is scraped

When the SAML handler scrapes exactly a single password, we verify it and
complete the authentication and login. This shaves off one extra password
the user has to type.

BUG=604309
TEST=browser_tests --gtest_filter=(SamlTest|SAMLEnrollmentTest|SAMLPolicyTest).*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f20568fcd6d73c9468b359f2ccd043c257e3c53b
Cr-Commit-Position: refs/heads/master@{#391646}
==========

[commit-bot: I haz the power, 2016-05-04 21:27:47]

Patchset 3 (id:??) landed as
https://crrev.com/f20568fcd6d73c9468b359f2ccd043c257e3c53b
Cr-Commit-Position: refs/heads/master@{#391646}