Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2803)

Unified Diff: base/trace_event/heap_profiler_allocation_register.h

Issue 1954443002: [tracing] Reduce number of buckets in AllocationRegister. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/heap_profiler_allocation_register.h
diff --git a/base/trace_event/heap_profiler_allocation_register.h b/base/trace_event/heap_profiler_allocation_register.h
index 804be898e4d1d4957d7f394404760fd0c8f96ca5..976f2f50a9c24ff1656a104c46ed8d289d6d1a6a 100644
--- a/base/trace_event/heap_profiler_allocation_register.h
+++ b/base/trace_event/heap_profiler_allocation_register.h
@@ -101,7 +101,7 @@ class BASE_EXPORT AllocationRegister {
Allocation allocation;
};
- // The number of buckets, 2^18, approximately 260 000, has been tuned for
+ // The number of buckets, 2^17, approximately 130 000, has been tuned for
// Chrome's typical number of outstanding allocations. (This number varies
// between processes. Most processes have a sustained load of ~30k unfreed
// allocations, but some processes have peeks around 100k-400k allocations.)
@@ -110,7 +110,7 @@ class BASE_EXPORT AllocationRegister {
// suggest that it is worthwile to use more memory for the table to avoid
// chasing down the linked list, until the size is 2^18. The number of buckets
// is a power of two so modular indexing can be done with bitwise and.
- static const uint32_t kNumBuckets = 0x40000;
+ static const uint32_t kNumBuckets = 0x20000;
static const uint32_t kNumBucketsMask = kNumBuckets - 1;
// Reserve address space to store at most this number of entries. High
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698