Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: Source/web/resources/calendarPicker.js

Issue 195443002: CalendarPicker display in correct format for minimum Value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added test expectations Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/win/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/resources/calendarPicker.js
diff --git a/Source/web/resources/calendarPicker.js b/Source/web/resources/calendarPicker.js
index 7f28be81849dc1297b6801a4bbb3cd0ad2237c21..0a7d18f94a4cc0f3eeea6fca729d40a3473a3fe9 100644
--- a/Source/web/resources/calendarPicker.js
+++ b/Source/web/resources/calendarPicker.js
@@ -1520,7 +1520,8 @@ ScrollView.prototype.onMouseWheel = function(event) {
ScrollView.prototype.setContentOffset = function(value) {
console.assert(isFinite(value));
value = Math.min(this.maximumContentOffset - this._height, Math.max(this.minimumContentOffset, Math.floor(value)));
- if (this._contentOffset === value)
+
+ if (this._contentOffset < 0)
keishi 2014/03/14 08:38:59 The original code's intent is to return early if t
Habib Virji 2014/03/14 10:38:15 Done.
return;
keishi 2014/03/14 08:38:59 I think I would separate out everything below this
Habib Virji 2014/03/14 10:38:15 Done.
var newPartitionNumber = Math.floor(value / ScrollView.PartitionHeight);
var partitionChanged = this._partitionNumber !== newPartitionNumber;
« no previous file with comments | « LayoutTests/platform/win/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698