CalendarPicker display in correct format for minimum Value

Source/web/resources/calendarPicker.js

 "use strict";
 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1502 matching lines @@
     event.preventDefault();
 };
 
 
 /**
  * @param {!number} value
  */
 ScrollView.prototype.setContentOffset = function(value) {
     console.assert(isFinite(value));
     value = Math.min(this.maximumContentOffset - this._height, Math.max(this.minimumContentOffset, Math.floor(value)));
-    if (this._contentOffset === value)
+
+    if (this._contentOffset < 0)

[keishi, 2014/03/14 08:38:59]

The original code's intent is to return early if the new content offset value is
the same as the current one. content offset should be able to take negative
values (as long as it is more than the minimumContentOffset). 

This change should be reverted.

[Habib Virji, 2014/03/14 10:38:15]

Done.

         return;

[keishi, 2014/03/14 08:38:59]

I think I would separate out everything below this line into a separate method
into something like ScrollView.prototype._updateScrollContent.

Then call it inside attachTo method.

ScrollView.prototype.attachTo = function(parent, before) {
    View.prototype.attachTo.call(this, parent, before);
    this._updateScrollContent();
};

[Habib Virji, 2014/03/14 10:38:15]

Done.

     var newPartitionNumber = Math.floor(value / ScrollView.PartitionHeight);    
     var partitionChanged = this._partitionNumber !== newPartitionNumber;
     this._partitionNumber = newPartitionNumber;
     this._contentOffset = value;
     this.contentElement.style.webkitTransform = "translate(0, " + (-this.contentPositionForContentOffset(this._contentOffset)) + "px)";
     if (this.delegate) {
         this.delegate.scrollViewDidChangeContentOffset(this);

[keishi, 2014/03/14 08:38:59]

Keep this line in setContentOffset()

[Habib Virji, 2014/03/14 10:38:15]

Done.

         if (partitionChanged)
             this.delegate.scrollViewDidChangePartition(this);
     }
 };
 
 /**
  * @param {!number} offset
  */
 ScrollView.prototype.contentPositionForContentOffset = function(offset) {
     return offset - this._partitionNumber * ScrollView.PartitionHeight;
@@ skipping 2483 matching lines @@
         event.stopPropagation();
         event.preventDefault();
     }
 }
 
 if (window.dialogArguments) {
     initialize(dialogArguments);
 } else {
     window.addEventListener("message", handleMessage, false);
 }