Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 19544002: Some tests involving AllocationSites are failing in GcStress test mode. (Closed)

Created:
7 years, 5 months ago by mvstanton
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Some tests involving AllocationSites are failing in GcStress test mode. The reason is that an AllocationMemento associated with an array only lives for one gc (it is unrooted). So an excess of garbage collections in these tests cause the Memento to be lost, and expected behavior can't be guaranteed. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M test/mjsunit/array-constructor-feedback.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Hannes, here is the fix we discussed. The wording around "GcStress" I got from ...
7 years, 5 months ago (2013-07-17 08:27:55 UTC) #1
Hannes Payer (out of office)
lgtm
7 years, 5 months ago (2013-07-17 08:29:53 UTC) #2
mvstanton
7 years, 5 months ago (2013-07-17 11:42:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698