Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1954343002: Remove ApplicationManagerTest.BCallC. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove ApplicationManagerTest.BCallC. (And also everything associated with it.) This test tests "exposed services" (a.k.a. wrong-way ServiceProviders), which we want to get rid of. R=vardhan@google.com BUG=#762 Committed: https://chromium.googlesource.com/external/mojo/+/7f38d695360a4c6ed2f0a58e1761c4ce01f84a4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -75 lines) Patch
M shell/application_manager/application_manager_unittest.cc View 7 chunks +3 lines, -69 lines 0 comments Download
M shell/application_manager/test.mojom View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
viettrungluu
4 years, 7 months ago (2016-05-06 23:01:12 UTC) #1
viettrungluu
+vardhan, in case he's around
4 years, 7 months ago (2016-05-09 19:42:48 UTC) #3
vardhan
lgtm
4 years, 7 months ago (2016-05-09 19:45:46 UTC) #4
viettrungluu
Committed patchset #1 (id:1) manually as 7f38d695360a4c6ed2f0a58e1761c4ce01f84a4d (presubmit successful).
4 years, 7 months ago (2016-05-09 19:53:19 UTC) #8
jeffbrown
4 years, 7 months ago (2016-05-09 19:55:18 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698