Chromium Code Reviews Chromium Code Reviews
Issue
1954313002:
Reland of Move about half of the clang/win bots to gn. (Closed)
DescriptionReland of Move about half of the clang/win bots to gn. (patchset #1 id:1 of https://codereview.chromium.org/1948303003/ )
Reason for revert:
32-bit clang/win/gn builds might work now.
Original issue's description:
> Revert of Move about half of the clang/win bots to gn. (patchset #1 id:1 of https://codereview.chromium.org/1947183004/ )
>
> Reason for revert:
> 32-bit builds fail like so:
> obj/chrome/installer/mini_installer/lib/chrome_appid.obj : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'X86'
>
> (The 64-bit bots look fine though.)
>
> Original issue's description:
> > Move about half of the clang/win bots to gn.
> >
> > The CrWinClang64(dbg) bot already is on gn. After this change, the
> > following bots will be on gn:
> >
> > Pinned:
> > CrWinClang
> > CrWinClang(shared)
> > CrWinClang64(dbg) (already on gn)
> >
> > ToT:
> > ClangToTWin(dll)
> > ClangToTWin64
> > ClangToTWin64(dll)
> >
> > These complement each other, so that each of
> > - 32-bit release static official
> > - 32-bit release shared
> > - 32-bit debug shared
> > - 64-bit release static official
> > - 64-bit release shared
> > - 64-bit debug shared
> > has one gyp and one gn bot (one a ToT bot, the other a pinned bot,
> > respectively).
> >
> > I'll also switch one of the ASan bots, but that's for a separate CL.
> >
> > Hopefully, no behavior change.
> >
> > BUG=498033
> > R=dpranke@chromium.org
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/dafacdab8ad432c98028eff432c09360f28254fe
>
> TBR=dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=498033
>
> Committed: https://crrev.com/0adf70552c219667ddf4df38752173f8d5dc801b
> Cr-Commit-Position: refs/heads/master@{#391976}
TBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498033
Committed: https://crrev.com/210c20eff22bee39130d425fed027e71c1a35020
Cr-Commit-Position: refs/heads/master@{#392179}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|
|||||||||||||||||||
