Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1954193002: [Monorail] Implement "Switch accounts" via google.com/a/SelectSession. (Closed)

Created:
4 years, 7 months ago by jrobbins
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, jrobbins+catch-up_google.com
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Monorail] Implement "Switch accounts" via google.com/a/SelectSession. Changing the URL from '/accounts/ServiceLogin' to '/a/SelectSession' always gives the user the chance to switch accounts, even if they are currently signed into exactly one account. Also, that account selection page looks nicer. The user will see both the google.com and the GAE account selectors the first time for each account, but it should not happen much after that if the user leaves "Remember this choice for 30 days" checked. R=seanmccullough@chromium.org BUG=monorail:438 Committed: https://chromium.googlesource.com/infra/infra/+/15b9f61d90423bcb2d240736e4a9401efddba42f

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M appengine/monorail/framework/servlet.py View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jrobbins
4 years, 7 months ago (2016-05-06 17:35:56 UTC) #1
jrobbins
Demo server https://3994-a874cb1-tainted-jrobbins-dot-monorail-staging.appspot.com
4 years, 7 months ago (2016-05-06 17:36:34 UTC) #2
seanmccullough1
lgtm Nice!
4 years, 7 months ago (2016-05-06 17:43:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954193002/1
4 years, 7 months ago (2016-05-06 21:52:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%2064%20Tester/builds/1756) ...
4 years, 7 months ago (2016-05-06 21:54:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954193002/20001
4 years, 7 months ago (2016-05-06 23:10:33 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 23:14:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/15b9f61d90423bcb2d240736e4a94...

Powered by Google App Engine
This is Rietveld 408576698