Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: net/quic/quic_stream_sequencer_buffer.cc

Issue 1954183002: Fix a QuicStreamSequencerBuffer logging issue caused by inapproriate itoa function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_sequencer_buffer.h" 5 #include "net/quic/quic_stream_sequencer_buffer.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "net/quic/quic_bug_tracker.h" 9 #include "net/quic/quic_bug_tracker.h"
10 10
11 using std::min; 11 using std::min;
12 using std::string; 12 using std::string;
13 13
14 namespace net { 14 namespace net {
15 15
16 namespace { 16 namespace {
17 17
18 string RangeDebugString(QuicStreamOffset start, QuicStreamOffset end) { 18 string RangeDebugString(QuicStreamOffset start, QuicStreamOffset end) {
19 return string("[") + base::IntToString(start) + ", " + 19 return string("[") + base::Uint64ToString(start) + ", " +
20 base::IntToString(end) + ") "; 20 base::Uint64ToString(end) + ") ";
21 } 21 }
22 22
23 } // namespace 23 } // namespace
24 24
25 QuicStreamSequencerBuffer::Gap::Gap(QuicStreamOffset begin_offset, 25 QuicStreamSequencerBuffer::Gap::Gap(QuicStreamOffset begin_offset,
26 QuicStreamOffset end_offset) 26 QuicStreamOffset end_offset)
27 : begin_offset(begin_offset), end_offset(end_offset) {} 27 : begin_offset(begin_offset), end_offset(end_offset) {}
28 28
29 QuicStreamSequencerBuffer::FrameInfo::FrameInfo() 29 QuicStreamSequencerBuffer::FrameInfo::FrameInfo()
30 : length(1), timestamp(QuicTime::Zero()) {} 30 : length(1), timestamp(QuicTime::Zero()) {}
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 QuicStreamOffset current_frame_begin_offset = it.first; 501 QuicStreamOffset current_frame_begin_offset = it.first;
502 QuicStreamOffset current_frame_end_offset = 502 QuicStreamOffset current_frame_end_offset =
503 it.second.length + current_frame_begin_offset; 503 it.second.length + current_frame_begin_offset;
504 current_frames_string += 504 current_frames_string +=
505 RangeDebugString(current_frame_begin_offset, current_frame_end_offset); 505 RangeDebugString(current_frame_begin_offset, current_frame_end_offset);
506 } 506 }
507 return current_frames_string; 507 return current_frames_string;
508 } 508 }
509 509
510 } // namespace net 510 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698