Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: src/x64/builtins-x64.cc

Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1188 __ movq(rax, rbx); 1188 __ movq(rax, rbx);
1189 1189
1190 // Lookup the argument in the number to string cache. 1190 // Lookup the argument in the number to string cache.
1191 Label not_cached, argument_is_string; 1191 Label not_cached, argument_is_string;
1192 NumberToStringStub::GenerateLookupNumberStringCache( 1192 NumberToStringStub::GenerateLookupNumberStringCache(
1193 masm, 1193 masm,
1194 rax, // Input. 1194 rax, // Input.
1195 rbx, // Result. 1195 rbx, // Result.
1196 rcx, // Scratch 1. 1196 rcx, // Scratch 1.
1197 rdx, // Scratch 2. 1197 rdx, // Scratch 2.
1198 false, // Input is known to be smi?
1199 &not_cached); 1198 &not_cached);
1200 __ IncrementCounter(counters->string_ctor_cached_number(), 1); 1199 __ IncrementCounter(counters->string_ctor_cached_number(), 1);
1201 __ bind(&argument_is_string); 1200 __ bind(&argument_is_string);
1202 1201
1203 // ----------- S t a t e ------------- 1202 // ----------- S t a t e -------------
1204 // -- rbx : argument converted to string 1203 // -- rbx : argument converted to string
1205 // -- rdi : constructor function 1204 // -- rdi : constructor function
1206 // -- rsp[0] : return address 1205 // -- rsp[0] : return address
1207 // ----------------------------------- 1206 // -----------------------------------
1208 1207
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR); 1434 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR);
1436 generator.Generate(); 1435 generator.Generate();
1437 } 1436 }
1438 1437
1439 1438
1440 #undef __ 1439 #undef __
1441 1440
1442 } } // namespace v8::internal 1441 } } // namespace v8::internal
1443 1442
1444 #endif // V8_TARGET_ARCH_X64 1443 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698